You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/18 14:33:11 UTC
[GitHub] [incubator-seatunnel] yx91490 opened a new pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
yx91490 opened a new pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
close #1092
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 edited a comment on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 edited a comment on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1019740938
ping @leo65535 can be merged? @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#discussion_r790199731
##########
File path: seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/command/CommandSparkArgs.java
##########
@@ -57,4 +59,11 @@ public boolean isTestConfig() {
return testConfig;
}
+ public String getMaster() {
Review comment:
make sense, but we can achive this goal in another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1016103425
hi @yx91490, can you add a unit test? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1019740938
ping @leo65535 can be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#discussion_r790134502
##########
File path: seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/command/CommandSparkArgs.java
##########
@@ -57,4 +59,11 @@ public boolean isTestConfig() {
return testConfig;
}
+ public String getMaster() {
Review comment:
Maybe we can assign a default value for the `master` variable to improve the ease of use, such as `local`. What do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 closed pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 closed pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 edited a comment on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 edited a comment on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1017125439
> hi @yx91490, can you add a unit test? thanks.
good suggestion, how do you think I should write? testing Jcommander's result seems meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1017196591
> > hi @yx91490, can you add a unit test? thanks.
>
> good suggestion, how do you think I should write? testing Jcommander's result seems meaningless.
you can refer `org.apache.seatunnel.config.command.CommandLineUtilsTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#discussion_r789652776
##########
File path: seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/command/CommandFlinkArgs.java
##########
@@ -42,4 +44,7 @@ public boolean isTestConfig() {
return testConfig;
}
+ public List<String> getVariables() {
Review comment:
UT used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 closed pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 closed pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 closed pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 closed pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1093: [Bug] [command] Fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1037082898
this pr was broken, continue to https://github.com/apache/incubator-seatunnel/pull/1236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1019791038
also cc @garyelephant, seems we didn't use these variables in main logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1017561637
> hi @yx91490, can you add a unit test? thanks.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#discussion_r789377219
##########
File path: seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/command/CommandFlinkArgs.java
##########
@@ -42,4 +44,7 @@ public boolean isTestConfig() {
return testConfig;
}
+ public List<String> getVariables() {
Review comment:
It seems that we never use `getVariables()` in main logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#discussion_r789653010
##########
File path: seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/command/CommandFlinkArgs.java
##########
@@ -42,4 +44,7 @@ public boolean isTestConfig() {
return testConfig;
}
+ public List<String> getVariables() {
Review comment:
> It seems that we never use `getVariables()` in main logic.
UT used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 closed pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 closed pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1093: [SeaTunnel #1092] fix "Can only specify option -i once" in command line args parser
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1093:
URL: https://github.com/apache/incubator-seatunnel/pull/1093#issuecomment-1017125439
> hi @yx91490, can you add a unit test? thanks.
good suggestion, what do you think I should write? testing Jcommander's result seems meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org