You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/05 15:50:27 UTC

[GitHub] [airflow] anitakar opened a new pull request #8718: Set store_serialized_dags from config in UI

anitakar opened a new pull request #8718:
URL: https://github.com/apache/airflow/pull/8718


   store_serialized_dags should be set to false everywhere except UI,
   experimental API and dag import
   
   Added missing store_serialized_dags to the _DagBag class.
   
   When I have applied store_serialized_dags from config everywhere I did
   not know/understand how this parameter works.
   
   It caused some problems:
   * migrations failed as they have used DagBag with SerializedDag before serialized_dags table was created
   * code that runs after all migrations and clean up dags took much longer as it was creating and saving serialized representations of dags
   * and, first of all, scheduler stopped parsing dags because
   DagBag::collect_dags method that it uses, returned no dags, as it does
   not collect dags when stored_serialized_dags is on.
   Generally, even though store_serialized_dags parameter is used in
   models and throughout common code, it should only be set to True in web
   server.
   If it is set to true in other parts of the system, they will stop
   working.
   CLI will stop working.
   Scheduler is the element that creates serialized dags and it should
   always read from disk to keep other parts of the system up to date.
   But there is no way to check whether dag_bag was called by web server and
   store_serialized_dags should be applied or if it was called from
   scheduler and dags should be read from files on the disk not from the db.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Target Github ISSUE in description if exists
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624157301


   > and, first of all, scheduler stopped parsing dags because
   > DagBag::collect_dags method that it uses, returned no dags, as it does
   > not collect dags when stored_serialized_dags is on.
   
   That's interesting, as we have been running with 1.10.7 and DAG serialzation on for a few months, and this is 100% not what we are seeing. Everything has been operating normally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624166423


   There are many users using Dag Serialization and have confirmed it is working for them, example: https://github.com/apache/airflow/issues/8247 is where we fixed the Bug. If you run using that docker-compose file, the Webserver does not have access to Dag Folder and it still works fine.
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] anitakar commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
anitakar commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-625364951


   > > Hi,
   > > I will collectively answer the questions here.
   > > Many of the changes that I have made have been a result of setting store_serialized_dags from conf in DagBag init method in one of squashed together commits.
   > > Before I decided that it is better to leave it with False default I started to change it to False in all places where it broke things.
   > > And it broke things in CLI, dag parsing code and this migration: airflow/migrations/versions/cc1e65623dc7_add_max_tries_column_to_task_instance.py
   > 
   > What error exactly? And is that error reproducible in Airflow 1.10.10, or is it only a problem in the Cloud Composer version?
   > 
   No, it is not a problem in Cloud Composer. At some point I made the change in DagBag to read store_serialized_dags instead of setting it to false but it was intermediate state. It was never released like that without a fix.
   > > This change is in fact noop so maybe we should drop it.
   > > It actually is about not reading core.store_serialized_dags on server startup. I had also problems with tests because of that. But if that operation is expensive and people will not probably be turning dag serialization on and off, then maybe it is better to drop it.
   > 
   > Airflow does not support changing config at runtime -- it is not possible. It is only the tests that are able to change settings.
   > 
   Then I shall drop the change of removing STORE_SERIALIZED_DAGS from settings.
   But the change is not a no-op in the end. It had different code for accessing dag code in UI that you fixed later on.
   Composer for a moment in Airflow 1.10.6 used storing, deleting and saving one by one but community version uses batch operations that I saw you had to fix.
   But there is an actual fix for non-RBAC www for setting paused on DAG. I shall create a test for it.
   I can also remember that we had problems with calling run from non-RBAC UI but I am sure if it was true for open sourced version somebody would have noticed it by now.
   > > Here is a similar change to Airflow 1.10.10:
   > > #8764
   > > This one actually fixes starting dag from UI.
   > > In this change I can also see dag async dag bag loading was dropped altogether in Airflow 1.10.10. Am I correct?
   > 
   > No, async dag bag loading was _never in_ Airflow. Either dag serialization is enabled, in which case the webserver loads it form the serialized tables in the DB, or it's not and the existing mechnaism is in place. Having a _third_ method of loading dags when dag serialization exists and fixes the performance overhead seems like extra code to maintain for little benefit.
   > 
   > Also: there is a reasonable chance that in Airflow 2.0 serializing dags may be the _only_ option.
   Oh, so it was Composer internal feature for clients with lots of DAGs. Anyways, our intention was to always contribute back to community, so I guess it is not a problem. But as there is serialized dags solution fully working this workaround can be dropped.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil edited a comment on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624186336






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624183495


   @kaxil This is a related problem. In one case, the store_serialzied_dag flag is not set on the Web UI. If it is set it should work. If @anitakar has Cloud Composer with example DAGs and DAG serialization turned on, it can be easily verified.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624186336


   > @kaxil This is a related problem. In one case, the store_serialzied_dag flag is not set on the Web UI. If it is set it should work. If @anitakar has Cloud Composer with example DAGs and DAG serialization turned on, it can be easily verified.
   
   Related to DAG Serialization but not related to PR description is what I mean


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil edited a comment on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624186336


   > @kaxil This is a related problem. In one case, the store_serialzied_dag flag is not set on the Web UI. If it is set it should work. If @anitakar has Cloud Composer with example DAGs and DAG serialization turned on, it can be easily verified.
   
   Related to DAG Serialization but not related to PR description is what I mean. Let's not club all DAG Serializations bugs in here.
   
   I have created an issue for Clearing the Task: https://github.com/apache/airflow/issues/8720. I will fix this for 1.10.11 but that issue is not being solved by this PR. @mik-laj 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624181386


   > Can you check if DAG cleaning works if it contains ExternalTaskMarker and recursive = True? In my opinion, this can still cause problems in some cases. Here is a potential path that can cause problems.
   > 
   > 1. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   >    
   >    or
   >    https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1156
   > 2. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   > 3. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1072
   > 4. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L956
   > 5. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1055
   > 6. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1083-L1084
   > 
   > Can you try running this DAG with serialization enabled and disabled?
   > https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/example_dags/example_external_task_marker_dag.py
   > If you will test on different versions of Airflow, can you also check how long the whole DAG Run will be done? I suspect there will be a big difference between Airflow 1.10.10 and older versions, but I haven't checked it yet.
   
   Isn't it a separate issue than the one mentioned in the PR description ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-625232783


   > Hi,
   > 
   > I will collectively answer the questions here.
   > 
   > Many of the changes that I have made have been a result of setting store_serialized_dags from conf in DagBag init method in one of squashed together commits.
   > Before I decided that it is better to leave it with False default I started to change it to False in all places where it broke things.
   > And it broke things in CLI, dag parsing code and this migration: airflow/migrations/versions/cc1e65623dc7_add_max_tries_column_to_task_instance.py
   
   What error exactly? And is that error reproducible in Airflow 1.10.10, or is it only a problem in the Cloud Composer version?
   
   > 
   > This change is in fact noop so maybe we should drop it.
   > It actually is about not reading core.store_serialized_dags on server startup. I had also problems with tests because of that. But if that operation is expensive and people will not probably be turning dag serialization on and off, then maybe it is better to drop it.
   
   Airflow does not support changing config at runtime -- it is not possible. It is only the tests that are able to change settings.
   
   > 
   > Here is a similar change to Airflow 1.10.10:
   > #8764
   > This one actually fixes starting dag from UI.
   > In this change I can also see dag async dag bag loading was dropped altogether in Airflow 1.10.10. Am I correct?
   
   No, async dag bag loading was _never in_ Airflow. Either dag serialization is enabled, in which case the webserver loads it form the serialized tables in the DB, or it's not and the existing mechnaism is in place. Having a _third_ method of loading dags when dag serialization exists and fixes the performance overhead seems like extra code to maintain for little benefit.
   
   
   Also: there is a reasonable chance that in Airflow 2.0 serializing dags may be the _only_ option.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624199695


   @kaxil Sorry for the mess. 
   
   Your ticket seems to me to describe another problem. In my opinion, the "Recursive" option is problematic. When I find a moment, I will confirm the bug and create a ticket.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624163465


   >store_serialized_dags should be set to false everywhere except UI,
   experimental API and dag import
   
   It is, isn't it ? The DagBag has store_serialized_dags to False as default:
   
   https://github.com/apache/airflow/blob/master/airflow/models/dagbag.py#L90
   
   And this is only changed to True inside the UI, experimental API and when writing DAGs in the Scheduler.
   
   
   >migrations failed as they have used DagBag with SerializedDag before serialized_dags table was created
   
   Can you point me to the migration that failed? None of the migrations creates a DagBag that override the `DagBag.store_serialized_dags=False`
   
   
   >and, first of all, scheduler stopped parsing dags because
   DagBag::collect_dags method that it uses, returned no dags, as it does
   not collect dags when stored_serialized_dags is on.
   Generally, even though store_serialized_dags parameter is used in
   models and throughout common code, it should only be set to True in web
   server.
   
   Same as above `DagBag::collect_dags method` uses self.store_serialized_dags which is default to False and the Scheduler does not override this.
   
   I think most of the points you made in the PR Description rely on an assumption that DagBag.store_serialized_dags is set to True when Dag Serialization is turned on, which is not True.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-625526747


   No problem @anitakar, it's good to check these things, and it's often easier to talk in code! (And sorry for being a bit curt!)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil edited a comment on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624181386


   > Can you check if DAG cleaning works if it contains ExternalTaskMarker and recursive = True? In my opinion, this can still cause problems in some cases. Here is a potential path that can cause problems.
   > 
   > 1. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   >    
   >    or
   >    https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1156
   > 2. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   > 3. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1072
   > 4. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L956
   > 5. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1055
   > 6. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1083-L1084
   > 
   > Can you try running this DAG with serialization enabled and disabled?
   > https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/example_dags/example_external_task_marker_dag.py
   > If you will test on different versions of Airflow, can you also check how long the whole DAG Run will be done? I suspect there will be a big difference between Airflow 1.10.10 and older versions, but I haven't checked it yet.
   
   Isn't it a separate issue (if it is an issue) than the one mentioned in the PR description?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj edited a comment on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624179448


   Can you check if DAG cleaning works if it contains ExternalTaskMarker and recursive = True? In my opinion, this can still cause problems in some cases. Here is a potential path that can cause problems.
   1. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   or 
   https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1156
   2. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   3. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1072
   4. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L956
   5. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1055
   6. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1083-L1084
   
   Can you try running this DAG with serialization enabled and disabled?
   https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/example_dags/example_external_task_marker_dag.py
   If you will test on different versions of Airflow, can you also check how long the whole DAG Run will be done? I suspect there will be a big difference between Airflow 1.10.10 and older versions, but I haven't checked it yet.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] anitakar commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
anitakar commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-625226724


   Hi,
   
   I will collectively answer the questions here.
   
   Many of the changes that I have made have been a result of setting store_serialized_dags from conf in DagBag init method in one of squashed together commits.
   Before I decided that it is better to leave it with False default I started to change it to False in all places where it broke things.
   And it broke things in CLI, dag parsing code and this migration: airflow/migrations/versions/cc1e65623dc7_add_max_tries_column_to_task_instance.py
   
   This change is in fact noop so maybe we should drop it.
   It actually is about not reading core.store_serialized_dags on server startup. I had also problems with tests because of that. But if that operation is expensive and people will not probably be turning dag serialization on and off, then maybe it is better to drop it.
   
   Here is a similar change to Airflow 1.10.10:
   https://github.com/apache/airflow/pull/8764
   This one actually fixes starting dag from UI.
   In this change I can also see dag async dag bag loading was dropped altogether in Airflow 1.10.10. Am I correct?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] anitakar commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
anitakar commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-625428708


   Closing the issue as only difference seems to be calling set_paused and its implementation has changed.
   Sorry for taking your time without checking everything first.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #8718: Set store_serialized_dags from config in UI

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8718:
URL: https://github.com/apache/airflow/pull/8718#issuecomment-624179448


   Can you check if DAG cleaning works if it contains ExternalTaskMarker? In my opinion, this can still cause problems in some cases. Here is a potential path that can cause problems.
   1. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   or 
   https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1156
   2. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1138
   3. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/www/views.py#L1072
   4. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L956
   5. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1055
   6. https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/models/dag.py#L1083-L1084
   
   Can you try running this DAG with serialization enabled and disabled?
   https://github.com/apache/airflow/blob/8d6f1aa4b5bb8809ffc55dc0c62e6d0e89f331e5/airflow/example_dags/example_external_task_marker_dag.py
   If you will test on different versions of Airflow, can you also check how long the whole DAG Run will be done? I suspect there will be a big difference between Airflow 1.10.10 and older versions, but I haven't checked it yet.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org