You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2020/08/19 18:33:16 UTC

[GitHub] [jmeter] weisJ opened a new pull request #613: Add documentation for Darklaf properties.

weisJ opened a new pull request #613:
URL: https://github.com/apache/jmeter/pull/613


   ## Description
   Provide documentation for some of the darklaf system properties.
   This PR also updates darklaf to version 2.4.5 as there have been issues with focus highlighting of table cells.
   Version 2.4.5 also provides the system property `darklaf.unifiedMenuBar` which toggles the unified menubar of darklaf.
   
   ## Motivation and Context
   Some people may be interested in using the custom window chrome feature of Darklaf (specifically on Windows).
   Because some people dislike unified menubars the corresponding property also is exposed.
   
   ## How Has This Been Tested?
   I'm not entirely sure how to test changes to the documentation. I would appreciate if someone could guide me here on what to do.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [x] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] asfgit closed pull request #613: Add documentation for Darklaf properties.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #613:
URL: https://github.com/apache/jmeter/pull/613


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on a change in pull request #613: Add documentation for Darklaf properties.

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on a change in pull request #613:
URL: https://github.com/apache/jmeter/pull/613#discussion_r474103018



##########
File path: src/core/src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java
##########
@@ -95,10 +95,16 @@ private static MenuItem ofDarklafTheme(Theme theme) {
     static {
         if (System.getProperty("darklaf.decorations") == null) {
             System.setProperty("darklaf.decorations", "false");
+        } else if ("true".equals(System.getProperty("darklaf.allowNativeCode"))) {

Review comment:
       Have you had a look at `Boolean.getBoolean(name)`? It should do the same as the `"true".equals(System.getProperty(...)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on pull request #613: Add documentation for Darklaf properties.

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #613:
URL: https://github.com/apache/jmeter/pull/613#issuecomment-677769389


   Thanks for the patch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on a change in pull request #613: Add documentation for Darklaf properties.

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on a change in pull request #613:
URL: https://github.com/apache/jmeter/pull/613#discussion_r474103018



##########
File path: src/core/src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java
##########
@@ -95,10 +95,16 @@ private static MenuItem ofDarklafTheme(Theme theme) {
     static {
         if (System.getProperty("darklaf.decorations") == null) {
             System.setProperty("darklaf.decorations", "false");
+        } else if ("true".equals(System.getProperty("darklaf.allowNativeCode"))) {

Review comment:
       Have you had a look at `Boolean.getValue(name)`? It should do the same as the `"true".equals(System.getProperty(...)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org