You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/12 21:25:19 UTC

[GitHub] [trafficserver-ingress-controller] rishabhc opened a new pull request #43: Adds instructions to install jaeger

rishabhc opened a new pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver-ingress-controller] shukitchan commented on pull request #43: Adds instructions to install jaeger

Posted by GitBox <gi...@apache.org>.
shukitchan commented on pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43#issuecomment-674295058


   pls make sure you use lua5.1 when building these opentracing libraries. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver-ingress-controller] rishabhc commented on pull request #43: Adds instructions to install jaeger

Posted by GitBox <gi...@apache.org>.
rishabhc commented on pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43#issuecomment-673657743


   I mentioned this in issue #20. So jaeger by itself is incomplete. We will have to use opentracing apis for any traces to be generated which can then be managed using jaeger. 
   To trace the requests going through ATS, we'll have to use the opentracing API with ATS. Something like this: https://github.com/opentracing-contrib/nginx-opentracing
   This is something that needs more discussion. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver-ingress-controller] shukitchan commented on pull request #43: Adds instructions to install jaeger

Posted by GitBox <gi...@apache.org>.
shukitchan commented on pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43#issuecomment-674302705


   also I find that you need opentracing-cpp-1.5.1 & lua-bridge-tracer-0.1.1 to make it work . latest opentracing-cpp-1.6.0 does not work with lua-bridge-tracer yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver-ingress-controller] shukitchan commented on pull request #43: Adds instructions to install jaeger

Posted by GitBox <gi...@apache.org>.
shukitchan commented on pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43#issuecomment-682361724


   I think I resolve the problem with using jaeger-client-cpp by opting to the plugin.so provided in the release. 
   
   I wrote a small example with instructions here to show how to integrate ATS with jaeger/opentracing/lua_bridge_tracer
   https://github.com/shukitchan/ats_lua_scripts/blob/master/tracer_example.lua


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver-ingress-controller] shukitchan commented on pull request #43: Adds instructions to install jaeger

Posted by GitBox <gi...@apache.org>.
shukitchan commented on pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43#issuecomment-681735839


   I tried using jaeger-client-cpp 0.4.2 as the tracer for the above. It is hard to get them to work with ATS. It is because both ATS and jaeger-client-cpp is using YAML library and they don't work well together. 
   
   perhaps I should try to use zipkin or lightstep instead


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver-ingress-controller] shukitchan commented on pull request #43: Adds instructions to install jaeger

Posted by GitBox <gi...@apache.org>.
shukitchan commented on pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43#issuecomment-674290726


   We can use this instead - https://github.com/opentracing/lua-bridge-tracer
   And simply write the lua code to create the needed data for the tracer. It can be inside https://github.com/apache/trafficserver-ingress-controller/blob/master/pluginats/connect_redis.lua and called as part of the request handling mechanism. 
   of course, tracing is optional, so we should have mechanism to allow us to turn it on and off. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver-ingress-controller] shukitchan commented on pull request #43: Adds instructions to install jaeger

Posted by GitBox <gi...@apache.org>.
shukitchan commented on pull request #43:
URL: https://github.com/apache/trafficserver-ingress-controller/pull/43#issuecomment-945017407


   We should be moving to use opentelemetry instead now. I am working on this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org