[jira] [Commented] (MESOS-2352) Scheduler::disconnected() should be called when the single master fails

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320994#comment-14320994 ] 

Benjamin Mahler commented on MESOS-2352:
----------------------------------------

Linking in related tickets to trigger disconnection on socket closures that may lessen the need for this.

> Scheduler::disconnected() should be called when the single master fails
> -----------------------------------------------------------------------
>
>                 Key: MESOS-2352
>                 URL: https://issues.apache.org/jira/browse/MESOS-2352
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>            Reporter: Alexander Rukletsov
>            Priority: Minor
>
> According to the comments in "scheduler.hpp", "sched.cpp" and also common sense, the {{Scheduler::disconnected()}} callback should be also invoked when master fails. However, in case of {{StandaloneMasterDetector}} this won't happen, since it doesn't track master failures. Though the {{StandaloneMasterDetector}} is not intended for production use, we should update it so that framework authors observe consistent behaviour and can test their frameworks in a single-master setup.
> As a short-term fix we may want to update comments in "scheduler.hpp" and "sched.cpp" for clarity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)