You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2015/05/27 16:24:59 UTC

svn commit: r1682043 - in /lucene/dev/branches/LUCENE-6481/lucene/sandbox/src: java/org/apache/lucene/search/GeoPointInBBoxQuery.java test/org/apache/lucene/search/TestGeoPointQuery.java

Author: mikemccand
Date: Wed May 27 14:24:58 2015
New Revision: 1682043

URL: http://svn.apache.org/r1682043
Log:
LUCENE-6481: add nocommit about query slowness for large bboxes; improve javadocs

Modified:
    lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/java/org/apache/lucene/search/GeoPointInBBoxQuery.java
    lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/test/org/apache/lucene/search/TestGeoPointQuery.java

Modified: lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/java/org/apache/lucene/search/GeoPointInBBoxQuery.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/java/org/apache/lucene/search/GeoPointInBBoxQuery.java?rev=1682043&r1=1682042&r2=1682043&view=diff
==============================================================================
--- lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/java/org/apache/lucene/search/GeoPointInBBoxQuery.java (original)
+++ lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/java/org/apache/lucene/search/GeoPointInBBoxQuery.java Wed May 27 14:24:58 2015
@@ -45,8 +45,8 @@ import org.apache.lucene.util.ToStringUt
  *    1.  All latitude/longitude values must be in decimal degrees.
  *    2.  Complex computational geometry (e.g., dateline wrapping) is not supported
  *    3.  For more advanced GeoSpatial indexing and query operations see spatial module
- *    4.  This is well suited for small rectangles, large bounding boxes, could result
- *        in visiting every term in terms dictionary (see LUCENE-6481)
+ *    4.  This is well suited for small rectangles, large bounding boxes result
+ *        in too many terms
  *
  * @lucene.experimental
  */

Modified: lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/test/org/apache/lucene/search/TestGeoPointQuery.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/test/org/apache/lucene/search/TestGeoPointQuery.java?rev=1682043&r1=1682042&r2=1682043&view=diff
==============================================================================
--- lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/test/org/apache/lucene/search/TestGeoPointQuery.java (original)
+++ lucene/dev/branches/LUCENE-6481/lucene/sandbox/src/test/org/apache/lucene/search/TestGeoPointQuery.java Wed May 27 14:24:58 2015
@@ -69,6 +69,9 @@ public class TestGeoPointQuery extends L
   @BeforeClass
   public static void beforeClass() throws Exception {
     directory = newDirectory();
+    
+    // nocommit when we randomly test the full lat/lon space it can result in very very slow query times ... is this expected?
+
     // Between 1.0 and 3.0:
     range = 2*(random().nextDouble() + 0.5);
     originLon = GeoUtils.MIN_LON_INCL + range + (GeoUtils.MAX_LON_INCL - GeoUtils.MIN_LON_INCL - 2*range) * random().nextDouble();