You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Mike Bowler <mb...@GargoyleSoftware.com> on 2003/01/27 03:04:46 UTC
[PATCH] Bug 16429 Align the code base with checkstyle
Here is the first step towards fixing the checkstyle warnings. I've
cleaned up warnings in quite a few files but lots still to go.
--
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : mbowler@GargoyleSoftware.com
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Mike Bowler <mb...@GargoyleSoftware.com>.
> A couple issues with the patch. The tests failed due to a change
> to the parameters member in HeaderElement.
Oops - my mistake. I'm usually fairly anal about running tests so I'm
not sure what happened there. I'll be more careful next time. Sorry.
> Also, I don't want to change to using any style that is contentious.
> In particular allowing members to be prefixed with an underscore.
Gotcha.
--
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : mbowler@GargoyleSoftware.com
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Jeffrey Dever <js...@sympatico.ca>.
Hey Mike,
A couple issues with the patch. The tests failed due to a change to the
parameters member in HeaderElement. A protected member was made to be
private and given an accessor. I think that this is a good change, but
patches should pass the tests before they are posted. The tests were
pretty bogus anyway, so I just patched them so its OK now. This is what
I had:
[java] There was 1 error:
[java] 1)
testOldMain(org.apache.commons.httpclient.TestHeaderElement)java.lang.NoSuchFieldError:
parameters
[java] at
org.apache.commons.httpclient.TestHeaderElement.testOldMain(TestHeaderElement.java:118)
[java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
[java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[java] FAILURES!!!
[java] Tests run: 161, Failures: 0, Errors: 1
Also, I don't want to change to using any style that is contentious. In
particular allowing members to be prefixed with an underscore. Its fine
to leave them untill this is ironed out, but don't add any new ones! I
commited the patch regardless because it represents several hours of
good work and can be changed (or not) later with a search and replace
depending on the decision.
Jandalf.
Mike Bowler wrote:
> I've added a second patch to the bug which fixes more checkstyle
> warnings. I'm still not sure why the patches were being discarded
> from my emails this morning so I'm just playing it safe and putting
> them in bugzilla.
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16429
>
>
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Jeffrey Dever <js...@sympatico.ca>.
I'd say that if there is a bugzilla bug for an issue, patches for that
issue should be posted to bugzilla. If there is no bug, send to the list.
Previously the bugzilla emails were being sent to the commons-dev list,
which was no good. I just recently had that changed so this list is the
default owner of our bugs so we will be better off.
Mike Bowler wrote:
> > shouldn't this be the default? Not everybody reading the list needs
> > all the patches, they increase only the list traffic.
>
> I don't really have a preference and am willing to do whatever the
> group wants. There seemed to be an awful lot of patches mailed to the
> commons-dev list so I assumed that this was the preferred way. For
> now, I'll stick with posting patches to bugzilla.
>
> Do the committers keep an eye on all the bug reports to see when a new
> patch has been submitted or should patches be announced on the list
> anyway? I'm all for keeping the list traffic down so if just
> uploading the patch to bugzilla is good enough then I'll stop there.
>
>
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Mike Bowler <mb...@GargoyleSoftware.com>.
> shouldn't this be the default? Not everybody reading the list needs
> all the patches, they increase only the list traffic.
I don't really have a preference and am willing to do whatever the group
wants. There seemed to be an awful lot of patches mailed to the
commons-dev list so I assumed that this was the preferred way. For now,
I'll stick with posting patches to bugzilla.
Do the committers keep an eye on all the bug reports to see when a new
patch has been submitted or should patches be announced on the list
anyway? I'm all for keeping the list traffic down so if just uploading
the patch to bugzilla is good enough then I'll stop there.
--
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : mbowler@GargoyleSoftware.com
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Joerg Heinicke <jo...@gmx.de>.
Mike Bowler wrote:
> I've added a second patch to the bug which fixes more checkstyle
> warnings. I'm still not sure why the patches were being discarded from
> my emails this morning so I'm just playing it safe and putting them in
> bugzilla.
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16429
Hi Mike,
shouldn't this be the default? Not everybody reading the list needs all
the patches, they increase only the list traffic. But everybody, who
needs a patch before it's added to CVS, can get it from Bugzilla.
Furthermore they couldn't get lost there. I definitely prefer Bugzilla
instead of mail attachement.
Regards,
Joerg
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Jeffrey Dever <js...@sympatico.ca>.
Ok, I thought we might wait on style related patches untill we finalize
some guidelines, but you have focused on issues not is dispute so thats
good. I do prefer patches to bugzilla, less traffic generated by email
(someone has to be paying for the apache bandwitdh).
Mike Bowler wrote:
> I've added a second patch to the bug which fixes more checkstyle
> warnings. I'm still not sure why the patches were being discarded
> from my emails this morning so I'm just playing it safe and putting
> them in bugzilla.
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16429
>
>
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Mike Bowler <mb...@GargoyleSoftware.com>.
I've added a second patch to the bug which fixes more checkstyle
warnings. I'm still not sure why the patches were being discarded from
my emails this morning so I'm just playing it safe and putting them in
bugzilla.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16429
--
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : mbowler@GargoyleSoftware.com
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Mike Bowler <mb...@GargoyleSoftware.com>.
> Ummm, there is no attachement to the email or the bug ...
This is wierd. I've sent it twice now and my sent folder shows both
messages having a patch attached but by the time it got back to me
through the list the patch was gone.
Anyway, I've attached the patch to the bug report now. Bug 16429.
--
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : mbowler@GargoyleSoftware.com
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Mike Bowler <mb...@GargoyleSoftware.com>.
Not sure what happened there. Lets try again.
Jeffrey Dever wrote:
> Ummm, there is no attachement to the email or the bug ...
>
>
> Mike Bowler wrote:
>
>> Here is the first step towards fixing the checkstyle warnings. I've
>> cleaned up warnings in quite a few files but lots still to go.
>>
>> ------------------------------------------------------------------------
>>
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : mbowler@GargoyleSoftware.com
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com
Re: [PATCH] Bug 16429 Align the code base with checkstyle
Posted by Jeffrey Dever <js...@sympatico.ca>.
Ummm, there is no attachement to the email or the bug ...
Mike Bowler wrote:
> Here is the first step towards fixing the checkstyle warnings. I've
> cleaned up warnings in quite a few files but lots still to go.
>
>------------------------------------------------------------------------
>
>--
>To unsubscribe, e-mail: <ma...@jakarta.apache.org>
>For additional commands, e-mail: <ma...@jakarta.apache.org>
>