You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "xcsnx (via GitHub)" <gi...@apache.org> on 2024/04/02 15:07:45 UTC

[I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

xcsnx opened a new issue, #5529:
URL: https://github.com/apache/shenyu/issues/5529

   ### Description
   
   Currently, there are many logging plugins in Shenyu that lack end-to-end (E2E) testing. It is necessary to improve the E2E testing for these logging plugins now. You can refer to the E2E testing of the RocketMQ logging plugin: https://github.com/apache/shenyu/pull/5439
   
   ### Task List
   
   - [ ] 1. Logging-ElasticSearch Plugin
   - [ ] 2. Logging-RabbitMq Plugin
   - [ ] 3. Logging-Kafka Plugin
   - [ ] 4 .Logging-Pulsar Plugin
   - [ ] 5. Logging-Clickhouse Plugin
   - [ ] 6. Logging-RocketMq Plugin (Finished)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "SleepySuke (via GitHub)" <gi...@apache.org>.
SleepySuke commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-6388208677

   @xcsnx May I take the Logging-ElasticSearch E2E item (task 1) in #5529?
   
   I checked master and `shenyu-e2e/shenyu-e2e-case/` currently only contains
   `logging-kafka` and `logging-rocketmq`; there is no Elasticsearch case yet,
   though several people expressed interest earlier in this thread without a
   merged PR. If the item is still unclaimed in practice, I'd like to work on it.
   
   My plan, following the structure of #5439 (RocketMQ) and #7415 (RabbitMQ):
   
   1. Add `shenyu-e2e-case-logging-elasticsearch` with a Testcontainers-backed
      real Elasticsearch container (no shared credentials, disposable).
   2. Drive gateway traffic, then query the index and assert the persisted
      record: status, headers and body fields.
   3. Cover a configuration refresh and a clean shutdown path.
   4. Wire the new case into the CI e2e matrix.
   
   Two questions before I start:
   - Is Elasticsearch staying in the main repository, or will it also move to
     `shenyu-plugin-store` like #7304/#7307? I don't want to land E2E in a
     module that is about to be externalized.
   - Any preference on the Elasticsearch image version to test against?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "zzzk1 (via GitHub)" <gi...@apache.org>.
zzzk1 commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2321565949

   Hi @xcsnx, can you assign `Logging-Kafka Plugin` part to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "HsiuChi (via GitHub)" <gi...@apache.org>.
HsiuChi commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2060312759

   Please assign part 1,2 to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "xcsnx (via GitHub)" <gi...@apache.org>.
xcsnx commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2680088123

   > Hello, [@xcsnx](https://github.com/xcsnx) ,i would like to try part 1,can you assign it to me?
   
   
   of course
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "kamiingithub (via GitHub)" <gi...@apache.org>.
kamiingithub commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2538072742

   Hi @xcsnx, pls assign part 1 and 5 to me
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "no-regret666 (via GitHub)" <gi...@apache.org>.
no-regret666 commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2678015673

   Hello, @xcsnx ,i would like to try part 1,can you assign it to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "xcsnx (via GitHub)" <gi...@apache.org>.
xcsnx commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2321956326

   > Hi @xcsnx, can you assign `Logging-Kafka Plugin` part to me?
   
   Certainly, but it seems that someone has already attempted to work on Kafka, yet there are still some issues. If you're interested, you can build upon their work to achieve the goal. For more details, please refer to the PR: https://github.com/apache/shenyu/pull/5540.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "sunnysabor (via GitHub)" <gi...@apache.org>.
sunnysabor commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-5943915926

   I opened PR #7415 for the RabbitMQ logging E2E subtask. It adds the RabbitMQ-backed E2E module and CI matrix routing, and leaves the umbrella issue open for the other logging plugins. The local module compile and matrix tests pass; the full local E2E run could not start because Docker Hub timed out pulling shenyu-admin, which is noted in the PR description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "RayayChung (via GitHub)" <gi...@apache.org>.
RayayChung commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2047108120

   pls assign logging-kafka to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "wjwang00 (via GitHub)" <gi...@apache.org>.
wjwang00 commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2757014478

   Hi @xcsnx ,If Task 4: Logging-Pulsar Plugin is not yet completed, I would like to try to finish it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "478320 (via GitHub)" <gi...@apache.org>.
478320 commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2406422309

   pls assign part 2 to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "ling0900 (via GitHub)" <gi...@apache.org>.
ling0900 commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2123968496

   Please assign one or more to me, I would like to do 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-2059544419

   I would like to try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Task] Add end-to-end (E2E) testing for logging plugins. [shenyu]

Posted by "SouthwestAsiaFloat (via GitHub)" <gi...@apache.org>.
SouthwestAsiaFloat commented on issue #5529:
URL: https://github.com/apache/shenyu/issues/5529#issuecomment-4489240792

   Hello @xcsnx ,if task 5 is not assigned at present, I'd like to take this task. Very appreciate if you could let me have this on me 😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org