You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2018/02/28 07:33:43 UTC
github reviews weirdness
Hey guys,
Noticed on some PR it is not possible to comment anymore the reviews
comments. This is quite bothering cause it makes the review comments split
and at the end quite hard to follow when you get > 1 iteration.
Anything important I miss here? Should I use another tool - if so, why not
github which is mainstream? Is it a "test" thing?
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Re: github reviews weirdness
Posted by Reuven Lax <re...@google.com>.
Yeah, I noticed the same thing. It's confusing.
On Tue, Feb 27, 2018 at 11:56 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Seems you are right Charles, not sure why it happens but found another
> place with the exact same content but with writable inputs. Thanks a lot!
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
> 2018-02-28 8:45 GMT+01:00 Charles Chen <cc...@google.com>:
>
>> I noticed that GitHub sometimes has two "copies" of a comment thread--the
>> first copy, the one that appears first on the page with the original
>> commenter, is the only one that allows comments; a second "copy" is created
>> when people do reviews. So maybe you can scroll up to find the right
>> "copy" of the thread to comment on.
>>
>>
>> On Tue, Feb 27, 2018, 11:34 PM Romain Manni-Bucau <rm...@gmail.com>
>> wrote:
>>
>>> Hey guys,
>>>
>>> Noticed on some PR it is not possible to comment anymore the reviews
>>> comments. This is quite bothering cause it makes the review comments split
>>> and at the end quite hard to follow when you get > 1 iteration.
>>>
>>> Anything important I miss here? Should I use another tool - if so, why
>>> not github which is mainstream? Is it a "test" thing?
>>>
>>>
>>> Romain Manni-Bucau
>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>> <http://rmannibucau.wordpress.com> | Github
>>> <https://github.com/rmannibucau> | LinkedIn
>>> <https://www.linkedin.com/in/rmannibucau> | Book
>>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>>
>>
>
Re: github reviews weirdness
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Seems you are right Charles, not sure why it happens but found another
place with the exact same content but with writable inputs. Thanks a lot!
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
2018-02-28 8:45 GMT+01:00 Charles Chen <cc...@google.com>:
> I noticed that GitHub sometimes has two "copies" of a comment thread--the
> first copy, the one that appears first on the page with the original
> commenter, is the only one that allows comments; a second "copy" is created
> when people do reviews. So maybe you can scroll up to find the right
> "copy" of the thread to comment on.
>
>
> On Tue, Feb 27, 2018, 11:34 PM Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>> Hey guys,
>>
>> Noticed on some PR it is not possible to comment anymore the reviews
>> comments. This is quite bothering cause it makes the review comments split
>> and at the end quite hard to follow when you get > 1 iteration.
>>
>> Anything important I miss here? Should I use another tool - if so, why
>> not github which is mainstream? Is it a "test" thing?
>>
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> | LinkedIn
>> <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>
Re: github reviews weirdness
Posted by Charles Chen <cc...@google.com>.
I noticed that GitHub sometimes has two "copies" of a comment thread--the
first copy, the one that appears first on the page with the original
commenter, is the only one that allows comments; a second "copy" is created
when people do reviews. So maybe you can scroll up to find the right
"copy" of the thread to comment on.
On Tue, Feb 27, 2018, 11:34 PM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Hey guys,
>
> Noticed on some PR it is not possible to comment anymore the reviews
> comments. This is quite bothering cause it makes the review comments split
> and at the end quite hard to follow when you get > 1 iteration.
>
> Anything important I miss here? Should I use another tool - if so, why not
> github which is mainstream? Is it a "test" thing?
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>