You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/08/12 13:07:24 UTC
[GitHub] [cxf] awrb opened a new pull request, #981: CXF-8750: only add trailing slash if necessary when locating webjars …
awrb opened a new pull request, #981:
URL: https://github.com/apache/cxf/pull/981
…resources for Swagger UI in OSGi environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #981:
URL: https://github.com/apache/cxf/pull/981#discussion_r944657369
##########
rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/OsgiSwaggerUiResolver.java:
##########
@@ -32,18 +31,24 @@ public class OsgiSwaggerUiResolver extends SwaggerUiResolver {
};
private final Class<? extends Annotation> annotationBundle;
+ private FrameworkUtilWrapper frameworkUtilWrapper;
Review Comment:
I believe the the introduction of the wrapper is for testability reasons? I would suggest to go with integration tests under `osgi\itests` instead, it would also help to catch any changes in Karaf (I could help with that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #981:
URL: https://github.com/apache/cxf/pull/981#discussion_r945193579
##########
rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/OsgiSwaggerUiResolver.java:
##########
@@ -32,18 +31,24 @@ public class OsgiSwaggerUiResolver extends SwaggerUiResolver {
};
private final Class<? extends Annotation> annotationBundle;
+ private FrameworkUtilWrapper frameworkUtilWrapper;
Review Comment:
Thank you @awrb , yes, `main` is in transition to Jakarta 9.1+ support, we could close this one (I will port the fix from 3.5.x to all other branches), thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …
Posted by GitBox <gi...@apache.org>.
reta commented on PR #981:
URL: https://github.com/apache/cxf/pull/981#issuecomment-1213336825
Thanks for the pull request @awrb , the change looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] awrb closed pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …
Posted by GitBox <gi...@apache.org>.
awrb closed pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …
URL: https://github.com/apache/cxf/pull/981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #981:
URL: https://github.com/apache/cxf/pull/981#discussion_r944657369
##########
rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/OsgiSwaggerUiResolver.java:
##########
@@ -32,18 +31,24 @@ public class OsgiSwaggerUiResolver extends SwaggerUiResolver {
};
private final Class<? extends Annotation> annotationBundle;
+ private FrameworkUtilWrapper frameworkUtilWrapper;
Review Comment:
I believe the the introduction of the wrapper is for testability reasons? I would suggest to go with integration tests instead, it would also help to catch any changes in Karaf (I could help with that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] awrb commented on a diff in pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …
Posted by GitBox <gi...@apache.org>.
awrb commented on code in PR #981:
URL: https://github.com/apache/cxf/pull/981#discussion_r944901593
##########
rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/OsgiSwaggerUiResolver.java:
##########
@@ -32,18 +31,24 @@ public class OsgiSwaggerUiResolver extends SwaggerUiResolver {
};
private final Class<? extends Annotation> annotationBundle;
+ private FrameworkUtilWrapper frameworkUtilWrapper;
Review Comment:
Thanks for the review @reta. Yes, the wrapper is for testability as FrameworkUtil is static. But I agree pax exam tests are a better idea than mocking OSGi. I added some but I couldn't get them to work on the main branch, due to some dependencies missing such as spring 6.0.0-M5 (I couldn't find it in central maven repo either - not sure how I can fetch these). So I opened a new PR based on 3.5.x-fixes: https://github.com/apache/cxf/pull/982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org