You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/04 08:17:27 UTC
[GitHub] [pulsar] Anonymitaet opened a new pull request #9800: [Doc] Add metrics for token and authentication
Anonymitaet opened a new pull request #9800:
URL: https://github.com/apache/pulsar/pull/9800
Add docs for https://github.com/apache/pulsar/pull/9321 and https://github.com/apache/pulsar/pull/9244.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9800: [Doc] Add metrics for token and authentication
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9800:
URL: https://github.com/apache/pulsar/pull/9800#discussion_r587336965
##########
File path: site2/docs/reference-metrics.md
##########
@@ -339,6 +341,31 @@ All the managed ledger bookie client metrics are labelled with the following lab
| pulsar_managedLedger_client_bookkeeper_ml_workers_task_execution | Summary | The worker task execution latency calculated in milliseconds. |
| pulsar_managedLedger_client_bookkeeper_ml_workers_task_queued | Summary | The worker task queued latency calculated in milliseconds. |
+### Token metrics
+
+All the token metrics are labelled with the following labels:
+
+- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you have configured in the `broker.conf` file.
+
+| Name | Type | Description |
+|---|---|---|
+| pulsar_expired_token_count | Counter | The number of Pulsar expired tokens. |
Review comment:
| pulsar_expired_token_count | Counter | The number of expired tokens in Pulsar. |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9800: [Doc] Add metrics for token and authentication
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9800:
URL: https://github.com/apache/pulsar/pull/9800#discussion_r587336279
##########
File path: site2/docs/reference-metrics.md
##########
@@ -400,4 +427,4 @@ All the proxy metrics are labelled with the following labels:
| split_read_latency_per_query | Summary | Total read latency per query. |
| split_record_deserialize_time | Summary | Time spent on deserializing message to record. For example, Avro, JSON, and so on. |
| split_record_deserialize_time_per_query | Summary | Time spent on deserializing message to record per query. |
-| split_total_execution_time | Summary | Total execution time . |
\ No newline at end of file
+| split_total_execution_time | Summary | Total execution time . |
Review comment:
```suggestion
| split_total_execution_time | Summary | The total execution time . |
```
##########
File path: site2/docs/reference-metrics.md
##########
@@ -400,4 +427,4 @@ All the proxy metrics are labelled with the following labels:
| split_read_latency_per_query | Summary | Total read latency per query. |
| split_record_deserialize_time | Summary | Time spent on deserializing message to record. For example, Avro, JSON, and so on. |
| split_record_deserialize_time_per_query | Summary | Time spent on deserializing message to record per query. |
-| split_total_execution_time | Summary | Total execution time . |
\ No newline at end of file
+| split_total_execution_time | Summary | Total execution time . |
Review comment:
```suggestion
| split_total_execution_time | Summary | The total execution time. |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9800: [Doc] Add metrics for token and authentication
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #9800:
URL: https://github.com/apache/pulsar/pull/9800#discussion_r587399479
##########
File path: site2/docs/reference-metrics.md
##########
@@ -339,6 +341,31 @@ All the managed ledger bookie client metrics are labelled with the following lab
| pulsar_managedLedger_client_bookkeeper_ml_workers_task_execution | Summary | The worker task execution latency calculated in milliseconds. |
| pulsar_managedLedger_client_bookkeeper_ml_workers_task_queued | Summary | The worker task queued latency calculated in milliseconds. |
+### Token metrics
+
+All the token metrics are labelled with the following labels:
+
+- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you have configured in the `broker.conf` file.
+
+| Name | Type | Description |
+|---|---|---|
+| pulsar_expired_token_count | Counter | The number of Pulsar expired tokens. |
+| pulsar_expiring_token_minutes | Histogram | The remaining time of expiring tokens in minutes. |
+
+### Authentication metrics
+
+All the authentication metrics are labelled with the following labels:
+
+- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you have configured in the `broker.conf` file.
+- *provider_name*: `provider_name=${provider_name}`. `${provider_name}` is the class name of the authentication provider.
+- *auth_method*: `auth_method=${auth_method}`. `${auth_method}` is the authentication method of the authentication provider.
+- *reason*: `reason=${reason}`. `${reason}` is the reason for failing authentication operation. (This label is only for `pulsar_authentication_failures_count`)
+
+| Name | Type | Description |
+|---|---|---|
+| pulsar_authentication_success_count| Counter | The number of successful authentication operations. |
+| pulsar_authentication_failures_count | Counter | The number of failing authentication operations. |
Review comment:
failing operation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9800: [Doc] Add metrics for token and authentication
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9800:
URL: https://github.com/apache/pulsar/pull/9800#discussion_r587337480
##########
File path: site2/docs/reference-metrics.md
##########
@@ -339,6 +341,31 @@ All the managed ledger bookie client metrics are labelled with the following lab
| pulsar_managedLedger_client_bookkeeper_ml_workers_task_execution | Summary | The worker task execution latency calculated in milliseconds. |
| pulsar_managedLedger_client_bookkeeper_ml_workers_task_queued | Summary | The worker task queued latency calculated in milliseconds. |
+### Token metrics
+
+All the token metrics are labelled with the following labels:
+
+- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you have configured in the `broker.conf` file.
+
+| Name | Type | Description |
+|---|---|---|
+| pulsar_expired_token_count | Counter | The number of Pulsar expired tokens. |
+| pulsar_expiring_token_minutes | Histogram | The remaining time of expiring tokens in minutes. |
+
+### Authentication metrics
+
+All the authentication metrics are labelled with the following labels:
+
+- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you have configured in the `broker.conf` file.
+- *provider_name*: `provider_name=${provider_name}`. `${provider_name}` is the class name of the authentication provider.
+- *auth_method*: `auth_method=${auth_method}`. `${auth_method}` is the authentication method of the authentication provider.
+- *reason*: `reason=${reason}`. `${reason}` is the reason for failing authentication operation. (This label is only for `pulsar_authentication_failures_count`)
+
+| Name | Type | Description |
+|---|---|---|
+| pulsar_authentication_success_count| Counter | The number of successful authentication operations. |
+| pulsar_authentication_failures_count | Counter | The number of failing authentication operations. |
Review comment:
failed or failing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #9800: [Doc] Add metrics for token and authentication
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #9800:
URL: https://github.com/apache/pulsar/pull/9800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #9800: [Doc] Add metrics for token and authentication
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #9800:
URL: https://github.com/apache/pulsar/pull/9800#issuecomment-790422528
@RobertIndie could you please help review? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org