[GitHub] [druid] bananaaggle edited a comment on pull request #11040: add avro stream input format

[GitBox <gi...@apache.org>]

bananaaggle edited a comment on pull request #11040:
URL: https://github.com/apache/druid/pull/11040#issuecomment-810245683


   > code LGTM 👍
   > 
   > This PR needs docs added to https://github.com/apache/druid/blob/master/docs/ingestion/data-formats.md I think before it is ready to go.
   > 
   > I think it should also be relatively easy to add an integration test for this since we already have an integration test for the `Parser` implementation of Avro + Schema Registry. All that needs done is a new `input_format` directory be created in this location https://github.com/apache/druid/tree/master/integration-tests/src/test/resources/stream/data/avro_schema_registry with a new `input_format.json` template (using the `InputFormat` instead of the `Parser`). See JSON for example: https://github.com/apache/druid/tree/master/integration-tests/src/test/resources/stream/data/json. If this template is added, then _i think_ it should be automatically picked up and run as part of the kafka data format integration tests.
   
   Sorry, I don't understand what you said. Do you mean an integration test is developing for Avro stream and when it finished, I can add a new json about this test? Or I need create this integration test by myself? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org