You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/09 15:28:49 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #1147: Internal Remove `GenericStringArray::from_vec` and `GenericStringArray::from_opt_vec`
alamb opened a new pull request #1147:
URL: https://github.com/apache/arrow-rs/pull/1147
# Which issue does this PR close?
Minor change
# Rationale for this change
Less code is easier to maintain and faster to compile
I noticed this while working on https://github.com/apache/arrow-rs/pull/1145. These two functions are totally redundant, and are not part of the public api (are `pub(crate)`)
# What changes are included in this PR?
1. remove named functions (including one `unsafe` usage) and update callsites
# Are there any user-facing changes?
1. No all functions are `pub(crate)`
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1147: Internal Remove `GenericStringArray::from_vec` and `GenericStringArray::from_opt_vec`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1147:
URL: https://github.com/apache/arrow-rs/pull/1147#issuecomment-1008321424
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1147](https://codecov.io/gh/apache/arrow-rs/pull/1147?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e88e526) into [master](https://codecov.io/gh/apache/arrow-rs/commit/719096b2d342dd3bf1f3f2226a26b93e19602852?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (719096b) will **decrease** coverage by `0.01%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/1147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 82.55% 82.54% -0.02%
==========================================
Files 169 169
Lines 50456 50436 -20
==========================================
- Hits 41655 41632 -23
- Misses 8801 8804 +3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow-rs/pull/1147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3N0cmluZy5ycw==) | `97.29% <66.66%> (+0.21%)` | :arrow_up: |
| [arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL21vZC5ycw==) | `93.11% <100.00%> (-0.03%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.69%)` | :arrow_down: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1147/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.52% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1147?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1147?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [719096b...e88e526](https://codecov.io/gh/apache/arrow-rs/pull/1147?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #1147: Internal Remove `GenericStringArray::from_vec` and `GenericStringArray::from_opt_vec`
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #1147:
URL: https://github.com/apache/arrow-rs/pull/1147#issuecomment-1010071335
Less code is nice :rocket:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1147: Internal Remove `GenericStringArray::from_vec` and `GenericStringArray::from_opt_vec`
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1147:
URL: https://github.com/apache/arrow-rs/pull/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org