[GitHub] [arrow] jonkeane commented on a change in pull request #10389: ARROW-12824: [R][CI] Upgrade builds for R 4.1 release

[GitBox <gi...@apache.org>]

jonkeane commented on a change in pull request #10389:
URL: https://github.com/apache/arrow/pull/10389#discussion_r638760747



##########
File path: .github/workflows/r.yml
##########
@@ -53,7 +53,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        r: ["3.6"]
+        r: ["4.0"]
         ubuntu: [18.04]

Review comment:
       I don't think this was listed on the ticket, but as good a time as any to bump this from 18.04 to 20.04.

##########
File path: .github/workflows/r.yml
##########
@@ -112,7 +112,7 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - { org: "rstudio", image: "r-base", tag: "4.0-centos7" }
+          - { org: "rstudio", image: "r-base", tag: "4.1-centos7" }
           - { org: "rhub", image: "debian-gcc-devel", tag: "latest" }

Review comment:
       I know this changes the way this is setup right now, but I wonder if it would make sense to have this build with centos + debian be R old release (4.0) and devel respectively and then have the ubuntu job up above be our current release job? 
   
   That would at least segregate the release from non-release, and make sure we're testing release on a modern(ish) OS compared to centos7 which has some interesting caveats due to its build system (it's good that we test centos7 here and not only in nightly, but it feels a little weird that that's our one linux release test).

##########
File path: .github/workflows/r.yml
##########
@@ -210,13 +210,12 @@ jobs:
       - uses: r-lib/actions/setup-r@master
         with:
           rtools-version: 40
-          r-version: "4.0"
+          r-version: "4.1"
           Ncpus: 2
       - uses: r-lib/actions/setup-r@master
-        if: ${{ matrix.rtools == 35 }}
         with:
-          rtools-version: 35
-          r-version: "3.6"
+          rtools-version: 40
+          r-version: "4.0"
           Ncpus: 2

Review comment:
       I think that you'll want to get rid of the second `uses: r-lib/actions/setup-r@master` block here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org