You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/11 20:46:58 UTC

[GitHub] [ozone] bharatviswa504 opened a new pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

bharatviswa504 opened a new pull request #1693:
URL: https://github.com/apache/ozone/pull/1693


   ## What changes were proposed in this pull request?
   
   Cleanup usage of VolumeArgs in Request/Response classes in Key requests.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4581
   
   ## How was this patch tested?
   
   Existing tests.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] linyiqun commented on a change in pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
linyiqun commented on a change in pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#discussion_r541644472



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##########
@@ -193,7 +193,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
 
       long scmBlockSize = ozoneManager.getScmBlockSize();
       int factor = omKeyInfo.getFactor().getNumber();
-      omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);
       omBucketInfo = getBucketInfo(omMetadataManager, volumeName, bucketName);

Review comment:
       Same comment like above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc commented on pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
captainzmc commented on pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#issuecomment-744366133


   Thanks for @bharatviswa504’s patch. Also thanks for the review of @linyiqun. Merged this. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] linyiqun commented on pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
linyiqun commented on pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#issuecomment-743938110


   @bharatviswa504 , would you mind checking if the failed unit related to this PR? If not, I am +1 for this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc commented on a change in pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
captainzmc commented on a change in pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#discussion_r541851499



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##########
@@ -279,7 +277,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           .collect(Collectors.toList());
       omKeyInfo.appendNewBlocks(newLocationList, false);
 
-      omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);

Review comment:
       All the use of the getVolumeInfo method has been removed, so getVolumeInfo should not be needed, we can [delete it.]( https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java#L620)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#issuecomment-743797356


   Thank You @linyiqun for the review, addressed review comments in the latest update.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#discussion_r541716018



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##########
@@ -279,7 +279,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           .collect(Collectors.toList());
       omKeyInfo.appendNewBlocks(newLocationList, false);
 
-      omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);

Review comment:
       I missed it, thanks for catching it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] captainzmc merged pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
captainzmc merged pull request #1693:
URL: https://github.com/apache/ozone/pull/1693


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] linyiqun commented on a change in pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
linyiqun commented on a change in pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#discussion_r541644472



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
##########
@@ -193,7 +193,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
 
       long scmBlockSize = ozoneManager.getScmBlockSize();
       int factor = omKeyInfo.getFactor().getNumber();
-      omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);
       omBucketInfo = getBucketInfo(omMetadataManager, volumeName, bucketName);

Review comment:
       Same comment for above.

##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##########
@@ -279,7 +279,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           .collect(Collectors.toList());
       omKeyInfo.appendNewBlocks(newLocationList, false);
 
-      omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);

Review comment:
       Why we not remove omVolumeArgs variable defined in this method? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] linyiqun edited a comment on pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
linyiqun edited a comment on pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#issuecomment-743938110


   @bharatviswa504 , would you mind checking if the failed unit test related to this PR? If not, I am +1 for this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1693: HDDS-4581. Cleanup usage of volumeArgs in KeyRequests.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #1693:
URL: https://github.com/apache/ozone/pull/1693#discussion_r542128035



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##########
@@ -279,7 +277,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
           .collect(Collectors.toList());
       omKeyInfo.appendNewBlocks(newLocationList, false);
 
-      omVolumeArgs = getVolumeInfo(omMetadataManager, volumeName);

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org