You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/05/16 19:49:02 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4231: Return NotFound for directories in Head and Get (#4230)
tustvold opened a new pull request, #4231:
URL: https://github.com/apache/arrow-rs/pull/4231
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4230
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I spent a non-trivial amount of time helping diagnose an issue with https://github.com/apache/arrow-datafusion/pull/6183 that boiled down to Azure a head request being made instead of a list request, because the `ListingTableUrl` didn't end with a `/`. Normally this would have returned a 404 NotFound which would have made the issue easy to identify, however, because it was a hierarchical namespace this didn't occur.
LocalFileSystem also runs into a similar issue.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
LocalFileSystem and MicrosoftAzure will no longer return directories for get and head requests
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] kylebrooks-8451 commented on a diff in pull request #4231: Return NotFound for directories in Head and Get (#4230)
Posted by "kylebrooks-8451 (via GitHub)" <gi...@apache.org>.
kylebrooks-8451 commented on code in PR #4231:
URL: https://github.com/apache/arrow-rs/pull/4231#discussion_r1195682716
##########
object_store/src/azure/client.rs:
##########
@@ -257,7 +257,19 @@ impl AzureClient {
path: path.as_ref(),
})?;
- Ok(response)
+ match response.headers().get("x-ms-resource-type") {
+ Some(resource) if resource.as_ref() != b"file" => {
+ Err(crate::Error::NotFound {
+ path: path.to_string(),
+ source: format!(
+ "Not a directory, got x-ms-resource-type: {}",
Review Comment:
Should this be, "Not a file"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4231: Return NotFound for directories in Head and Get (#4230)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4231:
URL: https://github.com/apache/arrow-rs/pull/4231#discussion_r1195627652
##########
object_store/src/local.rs:
##########
@@ -878,19 +883,25 @@ fn read_range(file: &mut File, path: &PathBuf, range: Range<usize>) -> Result<By
}
fn open_file(path: &PathBuf) -> Result<File> {
- let file = File::open(path).map_err(|e| {
- if e.kind() == std::io::ErrorKind::NotFound {
- Error::NotFound {
+ let file = match File::open(path).and_then(|f| Ok((f.metadata()?, f))) {
Review Comment:
This is potentially slightly unfortunate, in that we require an additional syscall, but I couldn't find a mechanism to only open files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4231: Return NotFound for directories in Head and Get (#4230)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4231:
URL: https://github.com/apache/arrow-rs/pull/4231#discussion_r1195683287
##########
object_store/src/azure/client.rs:
##########
@@ -257,7 +257,19 @@ impl AzureClient {
path: path.as_ref(),
})?;
- Ok(response)
+ match response.headers().get("x-ms-resource-type") {
+ Some(resource) if resource.as_ref() != b"file" => {
+ Err(crate::Error::NotFound {
+ path: path.to_string(),
+ source: format!(
+ "Not a directory, got x-ms-resource-type: {}",
Review Comment:
Oops lol
Edit: fixed, good spot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4231: Return NotFound for directories in Head and Get (#4230)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4231:
URL: https://github.com/apache/arrow-rs/pull/4231#discussion_r1195683287
##########
object_store/src/azure/client.rs:
##########
@@ -257,7 +257,19 @@ impl AzureClient {
path: path.as_ref(),
})?;
- Ok(response)
+ match response.headers().get("x-ms-resource-type") {
+ Some(resource) if resource.as_ref() != b"file" => {
+ Err(crate::Error::NotFound {
+ path: path.to_string(),
+ source: format!(
+ "Not a directory, got x-ms-resource-type: {}",
Review Comment:
Oops lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4231: Return NotFound for directories in Head and Get (#4230)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4231:
URL: https://github.com/apache/arrow-rs/pull/4231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org