You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/08/08 01:00:50 UTC

[GitHub] [incubator-ratis] amaliujia opened a new pull request #172: RATIS-1027. Implement un-finished tests in TestLogServiceProtoUtil

amaliujia opened a new pull request #172:
URL: https://github.com/apache/incubator-ratis/pull/172


   ## What changes were proposed in this pull request?
   Implement tests in TestLogServiceProtoUtil that were marked as TODO
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/RATIS-1027
   
   ## How was this patch tested?
   UT


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #172: RATIS-1027. Implement un-finished tests in TestLogServiceProtoUtil

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #172:
URL: https://github.com/apache/incubator-ratis/pull/172#issuecomment-671644726


   @joshelser thanks!
   
   The failed check is not relevant to this PR
   ```
   [ERROR] Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.368 s <<< FAILURE! - in org.apache.ratis.server.simulation.TestServerRestartWithSimulatedRpc
   [ERROR] testRestartFollower(org.apache.ratis.server.simulation.TestServerRestartWithSimulatedRpc)  Time elapsed: 9.885 s  <<< FAILURE!
   java.lang.AssertionError
   	at org.junit.Assert.fail(Assert.java:86)
   	at org.junit.Assert.assertTrue(Assert.java:41)
   	at org.junit.Assert.assertTrue(Assert.java:52)
   	at org.apache.ratis.server.ServerRestartTests.lambda$runTestRestartFollower$1(ServerRestartTests.java:116)
   	at org.apache.ratis.util.JavaUtils.attempt(JavaUtils.java:160)
   	at org.apache.ratis.util.JavaUtils.attemptRepeatedly(JavaUtils.java:146)
   	at org.apache.ratis.server.ServerRestartTests.runTestRestartFollower(ServerRestartTests.java:115)
   	at org.apache.ratis.MiniRaftCluster$Factory$Get.runWithNewCluster(MiniRaftCluster.java:125)
   	at org.apache.ratis.MiniRaftCluster$Factory$Get.runWithNewCluster(MiniRaftCluster.java:113)
   	at org.apache.ratis.server.ServerRestartTests.testRestartFollower(ServerRestartTests.java:91)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
   	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
   	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
   	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
   	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
   	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
   	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
   	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   	at java.lang.Thread.run(Thread.java:748)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] joshelser commented on pull request #172: RATIS-1027. Implement un-finished tests in TestLogServiceProtoUtil

Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #172:
URL: https://github.com/apache/incubator-ratis/pull/172#issuecomment-671654149


   > The failed check is not relevant to this PR
   
   Yup! I saw. Just pushed it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] joshelser closed pull request #172: RATIS-1027. Implement un-finished tests in TestLogServiceProtoUtil

Posted by GitBox <gi...@apache.org>.
joshelser closed pull request #172:
URL: https://github.com/apache/incubator-ratis/pull/172


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #172: RATIS-1027. Implement un-finished tests in TestLogServiceProtoUtil

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #172:
URL: https://github.com/apache/incubator-ratis/pull/172#issuecomment-670800174


   R: @joshelser 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org