You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2009/06/16 15:17:07 UTC

[jira] Created: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Attachment order is not preserved in Axiom 
-------------------------------------------

                 Key: WSCOMMONS-477
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
             Project: WS-Commons
          Issue Type: Bug
          Components: AXIOM
            Reporter: Rich Scheuerle
            Assignee: Rich Scheuerle


Scenario;

Axiom reads an inbound message message containing attachments.
Axiom writes the message so that it can be sent to another service.
The remote service fails because the attachments are sent in the wrong order.

Problem:
The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.

Solution:
I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen reopened WSCOMMONS-477:
---------------------------------------


The change in r785554 causes a regression in Axis2. The failing test case is org.apache.axis2.swa.EchoRawSwATest in module "integration". There is a server side failure with the following stack trace:

java.lang.NullPointerException
  at org.apache.axiom.om.impl.MIMEOutputUtils.createMimeBodyPart(MIMEOutputUtils.java:157)
  at org.apache.axiom.om.impl.MIMEOutputUtils.writeDataHandlerWithAttachmentsMessage(MIMEOutputUtils.java:326)
  at org.apache.axiom.om.impl.MIMEOutputUtils.writeSOAPWithAttachmentsMessage(MIMEOutputUtils.java:275)
  at org.apache.axis2.transport.http.SOAPMessageFormatter.writeSwAMessage(SOAPMessageFormatter.java:204)
  at org.apache.axis2.transport.http.SOAPMessageFormatter.writeTo(SOAPMessageFormatter.java:74)
  at org.apache.axis2.transport.http.CommonsHTTPTransportSender.sendUsingOutputStream(CommonsHTTPTransportSender.java:355)
  at org.apache.axis2.transport.http.CommonsHTTPTransportSender.invoke(CommonsHTTPTransportSender.java:232)
  at org.apache.axis2.engine.AxisEngine.send(AxisEngine.java:440)
  at org.apache.axis2.receivers.AbstractInOutSyncMessageReceiver.invokeBusinessLogic(AbstractInOutSyncMessageReceiver.java:45)
  at org.apache.axis2.receivers.AbstractMessageReceiver.receive(AbstractMessageReceiver.java:114)
  at org.apache.axis2.engine.AxisEngine.receive(AxisEngine.java:178)
  at org.apache.axis2.transport.http.HTTPTransportUtils.processHTTPPostRequest(HTTPTransportUtils.java:173)
  at org.apache.axis2.transport.http.HTTPWorker.service(HTTPWorker.java:267)
  at org.apache.axis2.transport.http.server.AxisHttpService.doService(AxisHttpService.java:281)
  at org.apache.axis2.transport.http.server.AxisHttpService.handleRequest(AxisHttpService.java:187)
  at org.apache.axis2.transport.http.server.HttpServiceProcessor.run(HttpServiceProcessor.java:82)
  at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
  at java.lang.Thread.run(Thread.java:613)

I will temporarily revert the change.

> Attachment order is not preserved in Axiom 
> -------------------------------------------
>
>                 Key: WSCOMMONS-477
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>             Fix For: Axiom 1.2.9
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Scenario;
> Axiom reads an inbound message message containing attachments.
> Axiom writes the message so that it can be sent to another service.
> The remote service fails because the attachments are sent in the wrong order.
> Problem:
> The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.
> Solution:
> I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle resolved WSCOMMONS-477.
--------------------------------------

    Resolution: Fixed

Committed revision 785554

Kudos to Tim Mitchell (IBM) for finding this issue and providing verification.

> Attachment order is not preserved in Axiom 
> -------------------------------------------
>
>                 Key: WSCOMMONS-477
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Scenario;
> Axiom reads an inbound message message containing attachments.
> Axiom writes the message so that it can be sent to another service.
> The remote service fails because the attachments are sent in the wrong order.
> Problem:
> The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.
> Solution:
> I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720631#action_12720631 ] 

Andreas Veithen commented on WSCOMMONS-477:
-------------------------------------------

Rich,

What is the reason to make this configurable? Why wouldn't we always write the attachments in the order they have been added (or read)? I don't see any situation where writing the attachments in random order (determined by the internals of HashMap or HashSet) would make sense.

> Attachment order is not preserved in Axiom 
> -------------------------------------------
>
>                 Key: WSCOMMONS-477
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Scenario;
> Axiom reads an inbound message message containing attachments.
> Axiom writes the message so that it can be sent to another service.
> The remote service fails because the attachments are sent in the wrong order.
> Problem:
> The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.
> Solution:
> I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davanum Srinivas resolved WSCOMMONS-477.
----------------------------------------

    Resolution: Fixed

please see r787001 for details.

http://svn.apache.org/viewvc?view=rev&revision=787001

thanks,
dims

> Attachment order is not preserved in Axiom 
> -------------------------------------------
>
>                 Key: WSCOMMONS-477
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>             Fix For: Axiom 1.2.9
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Scenario;
> Axiom reads an inbound message message containing attachments.
> Axiom writes the message so that it can be sent to another service.
> The remote service fails because the attachments are sent in the wrong order.
> Problem:
> The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.
> Solution:
> I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen updated WSCOMMONS-477:
--------------------------------------

    Fix Version/s: Axiom 1.2.9

> Attachment order is not preserved in Axiom 
> -------------------------------------------
>
>                 Key: WSCOMMONS-477
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>             Fix For: Axiom 1.2.9
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Scenario;
> Axiom reads an inbound message message containing attachments.
> Axiom writes the message so that it can be sent to another service.
> The remote service fails because the attachments are sent in the wrong order.
> Problem:
> The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.
> Solution:
> I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722351#action_12722351 ] 

Davanum Srinivas commented on WSCOMMONS-477:
--------------------------------------------

Andreas,

I'd let Rich answer that specifically. My guess is that he wants to preserve existing behavior as-is till we hit say Axiom 1.3. we may be being a bit more paranoid than required :)

-- dims

> Attachment order is not preserved in Axiom 
> -------------------------------------------
>
>                 Key: WSCOMMONS-477
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>             Fix For: Axiom 1.2.9
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Scenario;
> Axiom reads an inbound message message containing attachments.
> Axiom writes the message so that it can be sent to another service.
> The remote service fails because the attachments are sent in the wrong order.
> Problem:
> The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.
> Solution:
> I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-477) Attachment order is not preserved in Axiom

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722349#action_12722349 ] 

Andreas Veithen commented on WSCOMMONS-477:
-------------------------------------------

Dims,

Could you also answer the question I asked above about why this should actually be configurable and not be the default behavior?

Thanks,

Andreas

> Attachment order is not preserved in Axiom 
> -------------------------------------------
>
>                 Key: WSCOMMONS-477
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-477
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>             Fix For: Axiom 1.2.9
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Scenario;
> Axiom reads an inbound message message containing attachments.
> Axiom writes the message so that it can be sent to another service.
> The remote service fails because the attachments are sent in the wrong order.
> Problem:
> The order of the attachments is not preserved.  In most cases, this is not an issue because the receiving service will use mtom, swaref or other references to obtain the attachment information. However some older style SWA implementations or legacy vendors do rely on the attachment order.
> Solution:
> I am working on a small change and accompanying test to allow Axiom to preserve the attachment order.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.