You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ulysses-you (via GitHub)" <gi...@apache.org> on 2023/04/28 10:08:14 UTC
[GitHub] [spark] ulysses-you opened a new pull request, #40990: [SPARK-43317][SQL] Support combine adjacent aggregation
ulysses-you opened a new pull request, #40990:
URL: https://github.com/apache/spark/pull/40990
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add a new rule in `queryStagePreparationRules`. If there have adjacent aggregation with Partial and Final mode, we can combine them to Complete mode, so that we do not need to merge aggregation buffer.
For example:
```
HashAggregate (Final) HashAggregate (Complete)
| |
HashAggregate (Partial) => Exchange
|
Exchange
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improve performance
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
add test
```
OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1036-azure
Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Combine adjacent aggregation cardinality: 5: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
---------------------------------------------------------------------------------------------------------------------------
no adjacent aggregation 16383 16539 228 1.2 819.1 1.0X
combine adjacent aggregation - disable 11224 11345 187 1.8 561.2 1.5X
combine adjacent aggregation - enable 9769 9836 82 2.0 488.4 1.7X
Combine adjacent aggregation cardinality: 50: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
----------------------------------------------------------------------------------------------------------------------------
no adjacent aggregation 5197 5295 116 3.8 259.8 1.0X
combine adjacent aggregation - disable 8514 8811 258 2.3 425.7 0.6X
combine adjacent aggregation - enable 8500 8542 38 2.4 425.0 0.6X
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #40990: [SPARK-43317][SQL] Support combine adjacent aggregation
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40990:
URL: https://github.com/apache/spark/pull/40990#issuecomment-1722349664
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #40990: [SPARK-43317][SQL] Support combine adjacent aggregation
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #40990:
URL: https://github.com/apache/spark/pull/40990#issuecomment-1527324475
cc @cloud-fan @viirya if you have time to review, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #40990: [SPARK-43317][SQL] Support combine adjacent aggregation
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40990: [SPARK-43317][SQL] Support combine adjacent aggregation
URL: https://github.com/apache/spark/pull/40990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on a diff in pull request #40990: [SPARK-43317][SQL] Support combine adjacent aggregation
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #40990:
URL: https://github.com/apache/spark/pull/40990#discussion_r1180214993
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ReplaceHashWithSortAgg.scala:
##########
@@ -94,9 +94,13 @@ object ReplaceHashWithSortAgg extends Rule[SparkPlan] {
/**
* Check if `partialAgg` to be partial aggregate of `finalAgg`.
*/
- private def isPartialAgg(partialAgg: BaseAggregateExec, finalAgg: BaseAggregateExec): Boolean = {
+ def isPartialAgg(partialAgg: BaseAggregateExec, finalAgg: BaseAggregateExec): Boolean = {
+ // We should make sure the groupingExpressions of `partialAgg` and `finalAgg` are same
+ // to avoid final aggregate depends on the output of partial aggregate.
+ // For example: `Aggregate(Seq(Alias), Seq(Alias), ..)`.
if (partialAgg.aggregateExpressions.forall(_.mode == Partial) &&
- finalAgg.aggregateExpressions.forall(_.mode == Final)) {
+ finalAgg.aggregateExpressions.forall(_.mode == Final) &&
+ partialAgg.groupingExpressions == finalAgg.groupingExpressions) {
Review Comment:
this is a kind of bug before, as we construct `Aggregate(Seq(Alias), Seq(Alias), ..)` pattern in DPP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org