You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2015/07/02 20:35:05 UTC
[jira] [Commented] (CASSANDRA-9643) Warn when an extra-large
partition is compacted
[ https://issues.apache.org/jira/browse/CASSANDRA-9643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612339#comment-14612339 ]
Jonathan Ellis commented on CASSANDRA-9643:
-------------------------------------------
Hmm, I can't apply 5fd93eb8b6e82c7e6ad2c24dedab424e1865b164 to current 2.1. Can you rebase again?
Nit: no distinction is made for compaction algorithm on large partitions anymore, suggest the following language:
logger.warn("Compacting large partition {}/{}:{} ({} bytes)", metadata.ksName, metadata.cfName, keyString, rowSize);
> Warn when an extra-large partition is compacted
> -----------------------------------------------
>
> Key: CASSANDRA-9643
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9643
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Stefania
> Fix For: 2.1.x
>
>
> We used to log a warning when compacting an extra-large partition (CompactionController.getCompactedRow) but took that out as part of CASSANDRA-6142. Let's add back a warning. (Perhaps in SSTW.append, since MetadataCollector.update doesn't know the partition key and we will want to include that in the log.)
> Size threshold should be configurable in cassandra.yaml and default to 100MB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)