You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/26 22:34:37 UTC
[GitHub] [airflow] potiuk opened a new pull request, #23276: Fix left-over function in breeze-legacy
potiuk opened a new pull request, #23276:
URL: https://github.com/apache/airflow/pull/23276
Fixes: #23272
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23276: Fix left-over function in breeze-legacy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23276:
URL: https://github.com/apache/airflow/pull/23276#issuecomment-1110319337
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23276: Fix left-over function in breeze-legacy
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23276:
URL: https://github.com/apache/airflow/pull/23276#issuecomment-1110688622
> @potiuk Yep, I would have submitted a PR if I could figure out if we still needed it or not. smile
The sooner we get rid of the whole breeze-legacy - the better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on pull request #23276: Fix left-over function in breeze-legacy
Posted by GitBox <gi...@apache.org>.
blag commented on PR #23276:
URL: https://github.com/apache/airflow/pull/23276#issuecomment-1110336505
@potiuk Yep, I would have submitted a PR if I could figure out if we still needed it or not. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23276: Fix left-over function in breeze-legacy
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23276:
URL: https://github.com/apache/airflow/pull/23276#issuecomment-1110316063
cc: @blag -> BTW. For the future - we do not need issues for those. Next time you could simply make a PR fixing it (this is what we usually do when we see such simple bugs). Less overhead, less communication, faster fixes. No matter who fixes it, important is that it gets fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23276: Fix left-over function in breeze-legacy
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23276:
URL: https://github.com/apache/airflow/pull/23276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org