You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zentol (via GitHub)" <gi...@apache.org> on 2023/04/14 08:08:14 UTC

[GitHub] [flink] zentol opened a new pull request, #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

zentol opened a new pull request, #22399:
URL: https://github.com/apache/flink/pull/22399

   Adjusts the ITCaseRules to treat the `MiniClusterEnvironment` like a mini cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol commented on pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #22399:
URL: https://github.com/apache/flink/pull/22399#issuecomment-1514629936

   Updated, correctness is shown by the removed violation for `AvroBulkFormatITCase`.
   
   Other violations in the kafka IT cases are not addressed because the MiniClusterEnvironment is hidden in a `@Nested` class (that seems absolutely unnecessary on a side-note).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol commented on pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on PR #22399:
URL: https://github.com/apache/flink/pull/22399#issuecomment-1514604512

   Working on a v2; the rule wasn't adjusted correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] echauchot commented on pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

Posted by "echauchot (via GitHub)" <gi...@apache.org>.
echauchot commented on PR #22399:
URL: https://github.com/apache/flink/pull/22399#issuecomment-1514715881

   > Updated, correctness is shown by the removed violation for `AvroBulkFormatITCase`.
   > 
   
   yes I see that. AvroBulkFormatITCase belongs to one of the connectors that are using `@TestEnv` annotated `MiniClusterTestEnvironment` that still reside in the Flink main repo. Clever to use it as a test of the new architecture test rule.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22399:
URL: https://github.com/apache/flink/pull/22399#issuecomment-1508112354

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7b0c5b5f52e9af8424dbd18ad78f5462de8c71b3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7b0c5b5f52e9af8424dbd18ad78f5462de8c71b3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7b0c5b5f52e9af8424dbd18ad78f5462de8c71b3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] zentol merged pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol merged PR #22399:
URL: https://github.com/apache/flink/pull/22399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org