You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/01/19 02:45:23 UTC
[kudu-CR] [util] fixed env-test on OS X 10.11.5
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5738
Change subject: [util] fixed env-test on OS X 10.11.5
......................................................................
[util] fixed env-test on OS X 10.11.5
Prior to the fix, on some OS X 10.11.5 systems the uninitialized
portion of 64-bit variable was non-zero and since
the sysctlbyname("kern.maxfilesperproc", ...) call output just 4 bytes,
the value of the captured system property was wrong.
Calling setrlimit() with astronomical values did not succeed,
failing the env-test test.
Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
---
M src/kudu/util/env_posix.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/5738/1
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [util] fixed env-test on OS X
......................................................................
[util] fixed env-test on OS X
Prior to the fix, in some cases the uninitialized portion of 64-bit
variable was non-zero and since the sysctlbyname("kern.maxfilesperproc")
call output just 4 bytes, the value of the captured system property
was wrong. Calling setrlimit() with astronomical values did not succeed,
failing the env-test test.
Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
---
M src/kudu/util/env_posix.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/5738/2
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [util] fixed env-test on OS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] [util] fixed env-test on OS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [util] fixed env-test on OS X
......................................................................
[util] fixed env-test on OS X
Prior to the fix, in some cases the uninitialized portion of 64-bit
variable was non-zero and since the sysctlbyname("kern.maxfilesperproc")
call output just 4 bytes, the value of the captured system property
was wrong. Calling setrlimit() with astronomical values
did not succeed, failing the env-test test.
Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Reviewed-on: http://gerrit.cloudera.org:8080/5738
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/env_posix.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1274: uint64_t limit = 0;
> Using uint32_t should be OK because if for some reason the kernel begins ex
Well, sysctlbyname() never reads the oldp. However, given this standard 'read-into-a-scratchpad' scenario usually means you need to prepare/wipe the scratchpad before you pass it to the writer.
Ok, I'll remove the initialization, but I'll add a check to make sure the result size of the written data is not less than the size of the scratchpad variable.
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1274: uint64_t limit = 0;
Hmm, is it possible that uint64_t is the wrong type, and we should be using uint32_t to begin with? Or maybe we should be consulting len after the call to see how many bytes were actually written?
If not, could you document this strange behavior of sysctlbyname in a short comment here? Also, is this behavior deterministic on all OS X 10.11? Or does it write all 64-bits in some subversions?
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1274: uint64_t limit = 0;
> This behavior is documented in sysctlbyname() man page:
On-line man page for sysctlbyname() on OS X:
https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man3/sysctlbyname.3.html
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1274: uint64_t limit = 0;
> +1 for what Adar said above, man page also seem to state this:
I don't think we need to do call of sysctlbyname("kern.maxfilesperproc", nullptr, &len, ...) to discover the proper size of the variable -- the manual page has it documented as 32-bit integer. If, for some reason, they change that in the future releases and 32 bits is not enough, the sysctlbyname() should return ENOMEM and the CHECK() will fire. So, it's all safe.
Line 1277: l.rlim_max = limit;
> thinking aloud, rlim_max is a uint64_t struct variable, so I am hoping that
I'm not following: why would the rlimit struct be relevant here? The problem was in variable passed to sysctlbyname() itself.
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1274: uint32_t limit = 0;
> I don't think we need to do call of sysctlbyname("kern.maxfilesperproc", nu
Using uint32_t should be OK because if for some reason the kernel begins expecting a 64-bit integer, it'll return ENOMEM and we'll crash here.
But, could you remove the initialization of limit to 0? It's harmless, but it could be misinterpreted as signalling that sysctlbyname() reads the existing value of oldp, which it doesn't.
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1274: uint64_t limit = 0;
> On-line man page for sysctlbyname() on OS X:
+1 for what Adar said above, man page also seem to state this:
"The size of the available data can be determined by calling sysctl() with the NULL argument for oldp.
The size of the available data will be returned in the location pointed to by oldlenp. For some opera-tions, operations,
tions, the amount of space may change often. For these operations, the system attempts to round up so
that the returned size is large enough for a call to return the data shortly thereafter. "
Although this system parameter may not change its size at run time, we could always query the size of the data about to be written and allocate uint32 or uint64 based on what's returned by sysctl.
Line 1277: l.rlim_max = limit;
thinking aloud, rlim_max is a uint64_t struct variable, so I am hoping that structs have default constructors for the initialization of this variable before this assignment.
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(2 comments)
Thank you for the review.
http://gerrit.cloudera.org:8080/#/c/5738/2//COMMIT_MSG
Commit Message:
Line 14:
> Do you want to post the stacktrace of the failure ?
Nope, I don't want to post the stacktrace of the failure. IMO, doing so would not bring any value; it would just break the formatting of the commit message.
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1277: l.rlim_max = limit;
> Calling setrlimit down below with astronomical value was the original cause
Let me clarify: the 'rlim_max' _was_ initialized -- it was assigned the 'limit' value, where the 'limit' value was obtained from call to sysctlbyname(), which you can see from line 1277 of the code. The problem was that the 'limit' 64-bit variable passed to the sysctlbyname() was wider than the output of the function and those un-initialized extra bits were non-zero. That ended up as passing astronomical values in l.rlim_max.
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5738
to look at the new patch set (#5).
Change subject: [util] fixed env-test on OS X
......................................................................
[util] fixed env-test on OS X
Prior to the fix, in some cases the uninitialized portion of 64-bit
variable was non-zero and since the sysctlbyname("kern.maxfilesperproc")
call output just 4 bytes, the value of the captured system property
was wrong. Calling setrlimit() with astronomical values
did not succeed, failing the env-test test.
Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
---
M src/kudu/util/env_posix.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/5738/5
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5738
to look at the new patch set (#3).
Change subject: [util] fixed env-test on OS X
......................................................................
[util] fixed env-test on OS X
Prior to the fix, in some cases the uninitialized portion of 64-bit
variable was non-zero and since the sysctlbyname("kern.maxfilesperproc")
call output just 4 bytes, the value of the captured system property
was wrong. Calling setrlimit() with astronomical values did not succeed,
failing the env-test test.
Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
---
M src/kudu/util/env_posix.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/5738/3
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1274: uint64_t limit = 0;
> Hmm, is it possible that uint64_t is the wrong type, and we should be using
This behavior is documented in sysctlbyname() man page:
https://www.freebsd.org/cgi/man.cgi?query=sysctlbyname&apropos=0&sektion=3&format=html
The information is copied into the buffer specified by oldp. The size of
the buffer is given by the location specified by oldlenp before the call,
and that location gives the amount of data copied after a successful call
and after a call that returns with the error code ENOMEM. If the amount
of data available is greater than the size of the buffer supplied, the
call supplies as much data as fits in the buffer provided and returns
with the error code ENOMEM. If the old value is not desired, oldp and
oldlenp should be set to NULL.
This is not a strange behavior and it's deterministic. The function writes only the necessary bits, and returning the number of bytes written in the len parameter back. The non-deterministic part is in non-initialized variable.
Using 32-bit type is also an option: sysctlbyname man page on MacOS man page states that kern.maxfilesperproc returns 32-bit int. But what what wrong with using 64-bit?
If you prefer giving it exactly what it needs (32-bit) -- fine, I'll update this.
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: [util] fixed env-test on OS X
......................................................................
Patch Set 2:
(2 comments)
I am not seeing radio buttons on gerrit, perhaps some browser plugin issue I am facing at the moment, so consider +1 from my side.
http://gerrit.cloudera.org:8080/#/c/5738/2//COMMIT_MSG
Commit Message:
Line 14:
Do you want to post the stacktrace of the failure ?
http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 1277: l.rlim_max = limit;
> I'm not following: why would the rlimit struct be relevant here? The probl
Calling setrlimit down below with astronomical value was the original cause; So if rlim_max was uninitialized, 'rlim_max(uint64_t) = limit(uint32_t)' here will end up in same issue. But ignore this, I just confirmed that structs come with default constructors too, so this is safe.
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [util] fixed env-test on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5738
to look at the new patch set (#4).
Change subject: [util] fixed env-test on OS X
......................................................................
[util] fixed env-test on OS X
Prior to the fix, in some cases the uninitialized portion of 64-bit
variable was non-zero and since the sysctlbyname("kern.maxfilesperproc")
call output just 4 bytes, the value of the captured system property
was wrong. Calling setrlimit() with astronomical values
did not succeed, failing the env-test test.
Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
---
M src/kudu/util/env_posix.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/5738/4
--
To view, visit http://gerrit.cloudera.org:8080/5738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins