You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/12 09:30:03 UTC

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #258: Add / Fix / Complete javadoc

ok2c commented on a change in pull request #258:
URL: https://github.com/apache/httpcomponents-core/pull/258#discussion_r575090675



##########
File path: httpcore5-h2/src/main/java/org/apache/hc/core5/http2/nio/AsyncPingHandler.java
##########
@@ -49,6 +49,8 @@
      * Triggered to signal receipt of a ping response message.
      *
      * @param feedback the ping message feedback.
+     * @throws IOException in case of an I/O error

Review comment:
       @arturobernalg I honestly think this is just not worth it. `@throws IOException in case of an I/O error` adds no value to the javadocs. I am not sure what I am to do about this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org