You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/11/12 14:27:15 UTC

[GitHub] [lucene] gsmiller opened a new pull request #437: LUCENE-10232: Fix MultiRangeQuery to confirm all dimensions for a given range match

gsmiller opened a new pull request #437:
URL: https://github.com/apache/lucene/pull/437


   # Description
   
   `MultiRangeQuery` was incorrectly considering a range to match if at least one dimension matched (instead of requiring all dimensions to match).
   
   # Solution
   
   Corrected the logic in `MultiRangeQuery`. Also updated comparisons to use `ArrayUtil.ByteArrayComparator`.
   
   # Tests
   
   Updated existing tests to expose the bug and confirmed the fix addresses it.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [x] I have added tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] iverase commented on pull request #437: LUCENE-10232: Fix MultiRangeQuery to confirm all dimensions for a given range match

Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #437:
URL: https://github.com/apache/lucene/pull/437#issuecomment-982426508


   +1 to this fix, it doesn't make sense as it is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #437: LUCENE-10232: Fix MultiRangeQuery to confirm all dimensions for a given range match

Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #437:
URL: https://github.com/apache/lucene/pull/437#issuecomment-982432538


   I also like it that it uses the new comparator interface in ArrayUtil.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] gsmiller commented on pull request #437: LUCENE-10232: Fix MultiRangeQuery to confirm all dimensions for a given range match

Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #437:
URL: https://github.com/apache/lucene/pull/437#issuecomment-982972350


   Thanks @iverase , @uschindler , @jpountz !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] gsmiller merged pull request #437: LUCENE-10232: Fix MultiRangeQuery to confirm all dimensions for a given range match

Posted by GitBox <gi...@apache.org>.
gsmiller merged pull request #437:
URL: https://github.com/apache/lucene/pull/437


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org