You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/26 21:46:21 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #10304: Added DataprepGetJobGroupOperator and DataprepRunJobGroupOperator for Dataprep service

turbaszek commented on a change in pull request #10304:
URL: https://github.com/apache/airflow/pull/10304#discussion_r477607766



##########
File path: airflow/providers/google/cloud/hooks/dataprep.py
##########
@@ -40,7 +41,10 @@ class GoogleDataprepHook(BaseHook):
     def __init__(self, dataprep_conn_id: str = "dataprep_conn_id") -> None:
         super().__init__()
         self.dataprep_conn_id = dataprep_conn_id
-        self._url = "https://api.clouddataprep.com/v4/jobGroups"
+        conn = self.get_connection(self.dataprep_conn_id)
+        extra_dejson = conn.extra_dejson
+        self._token = extra_dejson.get("token")
+        self._base_url = extra_dejson.get("base_url", "https://api.clouddataprep.com")

Review comment:
       Nice!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org