[GitHub] [apisix-ingress-controller] tokers commented on pull request #694: feat: init ApisixPluginConfig crd #4 (#638)

[GitBox <gi...@apache.org>]

tokers commented on pull request #694:
URL: https://github.com/apache/apisix-ingress-controller/pull/694#issuecomment-976331016


   > @tao12345666333 I had fixed the lint error about my commits
   > 
   > ```shell
   > golangci-lint run
   > pkg/kube/apisix/apis/config/v2beta2/types.go:211: File is not `gofmt`-ed with `-s` (gofmt)
   > 	Status ApisixStatus  `json:"status,omitempty" yaml:"status,omitempty"`
   > pkg/apisix/plugin_test.go:25: File is not `goimports`-ed with -local github.com/apache/apisix-ingress-controller (goimports)
   > 	"github.com/apache/apisix-ingress-controller/pkg/metrics"
   > pkg/apisix/schema_test.go:24: File is not `goimports`-ed with -local github.com/apache/apisix-ingress-controller (goimports)
   > 	"github.com/apache/apisix-ingress-controller/pkg/metrics"
   > ```
   > 
   > But there were still some errors left:
   > 
   > ```shell
   > golangci-lint run
   > pkg/apisix/plugin_test.go:25: File is not `goimports`-ed with -local github.com/apache/apisix-ingress-controller (goimports)
   > 	"github.com/apache/apisix-ingress-controller/pkg/metrics"
   > pkg/apisix/schema_test.go:24: File is not `goimports`-ed with -local github.com/apache/apisix-ingress-controller (goimports)
   > 	"github.com/apache/apisix-ingress-controller/pkg/metrics"
   > ```
   > 
   > Maybe this caused by my latest golangci-lint `golangci-lint has version 1.42.1 built from 54f4301 on 2021-09-04T14:39:09Z` so what could I do to fix it or just ignore it
   
   If it's reported by the lint tool, let's fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org