You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/22 22:51:54 UTC

[GitHub] [commons-lang] toyopilgrim commented on pull request #780: LANG-1665 - Modify Tuple equals to take BigDecimal comparison

toyopilgrim commented on pull request #780:
URL: https://github.com/apache/commons-lang/pull/780#issuecomment-885285815


   @garydgregory  @aherbert 
   Thank you guys for the feedback. I'm convinced of all the discussions above. 
   
   >This issue suggests the need for a custom set of Number subclasses with a policy enum that dictates what kind of equality you want. But such a class belongs in Commons Numbers/Math, not Lang.
   
   This kind of feedback is exactly what I wanted. An intention of that ignorable PR is to receive a point of view like if there's a right place for it. Do you think that it'd be worth adding such a class in a right package?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org