You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Andy Heilveil (JIRA)" <ji...@apache.org> on 2010/09/28 00:01:37 UTC

[jira] Created: (PIVOT-648) useless ResultList constructors due to ignored argument

useless ResultList constructors due to ignored argument
-------------------------------------------------------

                 Key: PIVOT-648
                 URL: https://issues.apache.org/jira/browse/PIVOT-648
             Project: Pivot
          Issue Type: Bug
          Components: core-sql
    Affects Versions: 1.5.1
            Reporter: Andy Heilveil
            Priority: Minor


two constructors have identical bodies to other constructors due to ignored argument:
    public ResultList(ResultSet resultSet, Field... fields) {
        this(resultSet, false, new ArrayList<Field>(fields));
    }
vs
    public ResultList(ResultSet resultSet, boolean includeNullValues, Field... fields) {
        this(resultSet,    false   , new ArrayList<Field>(fields));
    }
and
    public ResultList(ResultSet resultSet, Sequence<Field> fields) {
        this(resultSet, false, new ArrayList<Field>(fields));
    }
vs
    public ResultList(ResultSet resultSet, boolean includeNullValues, Sequence<Field> fields) {
        this(resultSet,    false   , new ArrayList<Field>(fields));
    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (PIVOT-648) useless ResultList constructors due to ignored argument

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Brown resolved PIVOT-648.
------------------------------

    Fix Version/s: 1.5.2
                   2.0
       Resolution: Fixed

Good catch. However, this has already been fixed for both Pivot 1.5.2 and Pivot 2.0 (the ResultList class was refactored to resolve a fairly serious performance issue).

Thanks!


> useless ResultList constructors due to ignored argument
> -------------------------------------------------------
>
>                 Key: PIVOT-648
>                 URL: https://issues.apache.org/jira/browse/PIVOT-648
>             Project: Pivot
>          Issue Type: Bug
>          Components: core-sql
>    Affects Versions: 1.5.1
>            Reporter: Andy Heilveil
>            Priority: Minor
>             Fix For: 1.5.2, 2.0
>
>
> two constructors have identical bodies to other constructors due to ignored argument:
>     public ResultList(ResultSet resultSet, Field... fields) {
>         this(resultSet, false, new ArrayList<Field>(fields));
>     }
> vs
>     public ResultList(ResultSet resultSet, boolean includeNullValues, Field... fields) {
>         this(resultSet,    false   , new ArrayList<Field>(fields));
>     }
> and
>     public ResultList(ResultSet resultSet, Sequence<Field> fields) {
>         this(resultSet, false, new ArrayList<Field>(fields));
>     }
> vs
>     public ResultList(ResultSet resultSet, boolean includeNullValues, Sequence<Field> fields) {
>         this(resultSet,    false   , new ArrayList<Field>(fields));
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.