You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:32:12 UTC
[GitHub] [storm] liusheng opened a new pull request #3316: [STORM-3681] Enable basic ARM64 CI task
liusheng opened a new pull request #3316:
URL: https://github.com/apache/storm/pull/3316
## What is the purpose of the change
This change propose to add a basic ARM64 CI job into Travis configuration.
## How was the change tested
We have tested many times, there still have some problems about Travis ARM support, please see the STORM-3681 JIRA issue description. So we propose to added a basic ARM64 CI task as first step, which only run the "Client" module of Storm and is stable according to my testing. We will continue to track the issues of Travis ARM support, once the issues solved, we will try to enable all the Storm modules for ARM CI.
Testing of this change: https://github.com/liusheng/storm/pull/7/checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Yikun commented on pull request #3316: [STORM-3681] Enable basic ARM64 CI task
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #3316:
URL: https://github.com/apache/storm/pull/3316#issuecomment-666884859
cc @Ethanlm @srdo
It would be good you guys could take a look when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on a change in pull request #3316: [STORM-3681] Enable basic ARM64 CI task
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3316:
URL: https://github.com/apache/storm/pull/3316#discussion_r465102003
##########
File path: .travis.yml
##########
@@ -52,6 +54,7 @@ before_install:
- export MVN_HOME=$HOME/apache-maven-3.6.3
- if [ ! -d $MVN_HOME/bin ]; then wget https://archive.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz -P $HOME; tar xzvf $HOME/apache-maven-3.6.3-bin.tar.gz -C $HOME; fi
- export PATH=$MVN_HOME/bin:$PATH
+ - f=$(which javac); while [[ -L $f ]]; do f=$(readlink $f);done; export JAVA_HOME=${f%/bin/*}
Review comment:
Can you please elaborate why this is needed? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on a change in pull request #3316: [STORM-3681] Enable basic ARM64 CI task
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3316:
URL: https://github.com/apache/storm/pull/3316#discussion_r465769469
##########
File path: .travis.yml
##########
@@ -52,6 +54,7 @@ before_install:
- export MVN_HOME=$HOME/apache-maven-3.6.3
- if [ ! -d $MVN_HOME/bin ]; then wget https://archive.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz -P $HOME; tar xzvf $HOME/apache-maven-3.6.3-bin.tar.gz -C $HOME; fi
- export PATH=$MVN_HOME/bin:$PATH
+ - f=$(which javac); while [[ -L $f ]]; do f=$(readlink $f);done; export JAVA_HOME=${f%/bin/*}
Review comment:
Thanks for the detailed explanation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] liusheng commented on a change in pull request #3316: [STORM-3681] Enable basic ARM64 CI task
Posted by GitBox <gi...@apache.org>.
liusheng commented on a change in pull request #3316:
URL: https://github.com/apache/storm/pull/3316#discussion_r465411201
##########
File path: .travis.yml
##########
@@ -52,6 +54,7 @@ before_install:
- export MVN_HOME=$HOME/apache-maven-3.6.3
- if [ ! -d $MVN_HOME/bin ]; then wget https://archive.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz -P $HOME; tar xzvf $HOME/apache-maven-3.6.3-bin.tar.gz -C $HOME; fi
- export PATH=$MVN_HOME/bin:$PATH
+ - f=$(which javac); while [[ -L $f ]]; do f=$(readlink $f);done; export JAVA_HOME=${f%/bin/*}
Review comment:
Hi Ethanlm,
Thanks for your review.
There is an existed problem of Travis CI "JAVA_HOME is not exported for arm64 architecture", see:
https://travis-ci.community/t/java-home-is-not-exported-for-arm64-architecture/6993/3
in the above issue, there is an workaround mentioned, which is this line of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm merged pull request #3316: [STORM-3681] Enable basic ARM64 CI task
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3316:
URL: https://github.com/apache/storm/pull/3316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] liusheng commented on a change in pull request #3316: [STORM-3681] Enable basic ARM64 CI task
Posted by GitBox <gi...@apache.org>.
liusheng commented on a change in pull request #3316:
URL: https://github.com/apache/storm/pull/3316#discussion_r465411201
##########
File path: .travis.yml
##########
@@ -52,6 +54,7 @@ before_install:
- export MVN_HOME=$HOME/apache-maven-3.6.3
- if [ ! -d $MVN_HOME/bin ]; then wget https://archive.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz -P $HOME; tar xzvf $HOME/apache-maven-3.6.3-bin.tar.gz -C $HOME; fi
- export PATH=$MVN_HOME/bin:$PATH
+ - f=$(which javac); while [[ -L $f ]]; do f=$(readlink $f);done; export JAVA_HOME=${f%/bin/*}
Review comment:
Hi Ethanlm,
Thanks for your review.
There is an existed problem of Travis CI "JAVA_HOME is not exported for arm64 architecture", see:
https://travis-ci.community/t/java-home-is-not-exported-for-arm64-architecture/6993/3
in the issue, there is an workaround mentioned, which is this line of code. I have confirmed the problem and verified this workaround.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] liusheng commented on a change in pull request #3316: [STORM-3681] Enable basic ARM64 CI task
Posted by GitBox <gi...@apache.org>.
liusheng commented on a change in pull request #3316:
URL: https://github.com/apache/storm/pull/3316#discussion_r465411201
##########
File path: .travis.yml
##########
@@ -52,6 +54,7 @@ before_install:
- export MVN_HOME=$HOME/apache-maven-3.6.3
- if [ ! -d $MVN_HOME/bin ]; then wget https://archive.apache.org/dist/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz -P $HOME; tar xzvf $HOME/apache-maven-3.6.3-bin.tar.gz -C $HOME; fi
- export PATH=$MVN_HOME/bin:$PATH
+ - f=$(which javac); while [[ -L $f ]]; do f=$(readlink $f);done; export JAVA_HOME=${f%/bin/*}
Review comment:
Hi Ethanlm,
Thanks for your review.
There is an existed problem of Travis CI "JAVA_HOME is not exported for arm64 architecture", see:
https://travis-ci.community/t/java-home-is-not-exported-for-arm64-architecture/6993/3
in the issue, there is an workaround mentioned, which is this line of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org