You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jung JaeHwa <jh...@gruter.com> on 2014/02/14 10:43:09 UTC
Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs
-----
dev-support/findbugs-exclude.xml 0f967de
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java 2f57ff2
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/MutableBoolean.java PRE-CREATION
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java 62d6e27
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/#review34695
-----------------------------------------------------------
Ship it!
+1
The latest patch looks nice for me. I leaved some trivial comments. Please handle them before you commit the patch.
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
<https://reviews.apache.org/r/18112/#comment64910>
I live this part!
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
<https://reviews.apache.org/r/18112/#comment64911>
Schema class implements Cloneable interface. So, it would be better to throw CloneNotSupportedException instead of catching this exception.
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java
<https://reviews.apache.org/r/18112/#comment64909>
It may be necessary. I would like to suggest Preconditions.checkNotNull(). It looks better and is widely used in other parts.
- Hyunsik Choi
On Feb. 18, 2014, 4:38 p.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18112/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 4:38 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-530
> https://issues.apache.org/jira/browse/TAJO-530
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Fix warnings in tajo-catalog.
>
>
> Diffs
> -----
>
> dev-support/findbugs-exclude.xml 0f967de
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
>
> Diff: https://reviews.apache.org/r/18112/diff/
>
>
> Testing
> -------
>
> mvn clean test findbugs:findbugs -Phcatalog-0.12.0
> mvn clean test findbugs:findbugs -Phcatalog-0.11.0
>
>
> Thanks,
>
> Jung JaeHwa
>
>
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/#review34804
-----------------------------------------------------------
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
<https://reviews.apache.org/r/18112/#comment65151>
This is a typo. I intended to say 'love this patch'.
- Hyunsik Choi
On Feb. 18, 2014, 4:38 p.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18112/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 4:38 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-530
> https://issues.apache.org/jira/browse/TAJO-530
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Fix warnings in tajo-catalog.
>
>
> Diffs
> -----
>
> dev-support/findbugs-exclude.xml 0f967de
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
>
> Diff: https://reviews.apache.org/r/18112/diff/
>
>
> Testing
> -------
>
> mvn clean test findbugs:findbugs -Phcatalog-0.12.0
> mvn clean test findbugs:findbugs -Phcatalog-0.11.0
>
>
> Thanks,
>
> Jung JaeHwa
>
>
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/#review34858
-----------------------------------------------------------
Ship it!
+1
Thank you for your contribution.
- Hyunsik Choi
On Feb. 19, 2014, 2:48 p.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18112/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 2:48 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-530
> https://issues.apache.org/jira/browse/TAJO-530
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Fix warnings in tajo-catalog.
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java 8310873
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java 984ba6a
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java efa1e05
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java 7b88fa5
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java a0c0eeb
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/SchemaUtil.java 9f7d23d
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java fbfc76f
>
> Diff: https://reviews.apache.org/r/18112/diff/
>
>
> Testing
> -------
>
> mvn clean test findbugs:findbugs -Phcatalog-0.12.0
> mvn clean test findbugs:findbugs -Phcatalog-0.11.0
>
>
> Thanks,
>
> Jung JaeHwa
>
>
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 5:48 a.m.)
Review request for Tajo.
Changes
-------
I updated the patch for Hyunsik's comments.
Please review it again.:)
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs (updated)
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java 8310873
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java 984ba6a
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java efa1e05
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java 7b88fa5
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java a0c0eeb
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/SchemaUtil.java 9f7d23d
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java fbfc76f
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/#review34833
-----------------------------------------------------------
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
<https://reviews.apache.org/r/18112/#comment65209>
I think that all methods of CatalogStore should throw CatalogException instead of SQLException. This is because CatalogStore is not intended to use only JDBC drivers. SQLException should be handled in concrete classes of CatalogStore.
- Hyunsik Choi
On Feb. 19, 2014, 11:27 a.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18112/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 11:27 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-530
> https://issues.apache.org/jira/browse/TAJO-530
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Fix warnings in tajo-catalog.
>
>
> Diffs
> -----
>
> dev-support/findbugs-exclude.xml 0f967de
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java 8310873
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java 984ba6a
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java efa1e05
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java f390b52
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java 7b88fa5
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java a0c0eeb
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryUnitRequestImpl.java d4006e0
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java fbfc76f
>
> Diff: https://reviews.apache.org/r/18112/diff/
>
>
> Testing
> -------
>
> mvn clean test findbugs:findbugs -Phcatalog-0.12.0
> mvn clean test findbugs:findbugs -Phcatalog-0.11.0
>
>
> Thanks,
>
> Jung JaeHwa
>
>
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 2:27 a.m.)
Review request for Tajo.
Changes
-------
Hyunsik, Thank you for your review.
I updated the patch for your comments.
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs (updated)
-----
dev-support/findbugs-exclude.xml 0f967de
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java 8310873
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java 984ba6a
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java efa1e05
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java f390b52
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java 7b88fa5
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java a0c0eeb
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryUnitRequestImpl.java d4006e0
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java fbfc76f
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 7:38 a.m.)
Review request for Tajo.
Changes
-------
Schema conflicted with latest version, so I rebased to the latest master branch.
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs (updated)
-----
dev-support/findbugs-exclude.xml 0f967de
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 7:25 a.m.)
Review request for Tajo.
Changes
-------
I updated codes for closing jdbc resources, and updated exception type of CatalogStore.
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs (updated)
-----
dev-support/findbugs-exclude.xml 0f967de
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java 8a824bd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
(Updated Feb. 17, 2014, 3:03 p.m.)
Review request for Tajo.
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs (updated)
-----
dev-support/findbugs-exclude.xml 0f967de
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
(Updated Feb. 17, 2014, 1:34 p.m.)
Review request for Tajo.
Changes
-------
I update the patch as follows:
- remove an unnecessary filter at findbugs_exclude.xml.
- change closing method for jdbc objects.
- other bugs
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs (updated)
-----
dev-support/findbugs-exclude.xml 0f967de
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 95bd83d
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java f253151
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jinho Kim <jh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/#review34630
-----------------------------------------------------------
dev-support/findbugs-exclude.xml
<https://reviews.apache.org/r/18112/#comment64821>
Jaehwa,
'store.*' will be skipped real bugs.
please refer to link. we need other solution.
http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/DbUtils.java?view=markup
- Jinho Kim
On Feb. 17, 2014, 6:06 a.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18112/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 6:06 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-530
> https://issues.apache.org/jira/browse/TAJO-530
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Fix warnings in tajo-catalog.
>
>
> Diffs
> -----
>
> dev-support/findbugs-exclude.xml 0f967de
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java 2f57ff2
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
>
> Diff: https://reviews.apache.org/r/18112/diff/
>
>
> Testing
> -------
>
> mvn clean test findbugs:findbugs -Phcatalog-0.12.0
> mvn clean test findbugs:findbugs -Phcatalog-0.11.0
>
>
> Thanks,
>
> Jung JaeHwa
>
>
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/
-----------------------------------------------------------
(Updated Feb. 17, 2014, 6:06 a.m.)
Review request for Tajo.
Changes
-------
Hi, Hyunsik.
Thank you for your review.
I updated sources by your comments.
Please review it again. :)
Bugs: TAJO-530
https://issues.apache.org/jira/browse/TAJO-530
Repository: tajo
Description
-------
Fix warnings in tajo-catalog.
Diffs (updated)
-----
dev-support/findbugs-exclude.xml 0f967de
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java 2f57ff2
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java cf13a9d
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
Diff: https://reviews.apache.org/r/18112/diff/
Testing
-------
mvn clean test findbugs:findbugs -Phcatalog-0.12.0
mvn clean test findbugs:findbugs -Phcatalog-0.11.0
Thanks,
Jung JaeHwa
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Jung JaeHwa <jh...@gruter.com>.
> On Feb. 15, 2014, 5:36 p.m., Hyunsik Choi wrote:
> > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java, line 658
> > <https://reviews.apache.org/r/18112/diff/1/?file=485062#file485062line658>
> >
> > What was the reasoning behind the removal of compareTo function?
I removed this method because findbugs searched a bug called EQ_COMPARETO_USE_OBJECT_EQUALS as follows:
http://findbugs.sourceforge.net/bugDescriptions.html#EQ_COMPARETO_USE_OBJECT_EQUALS
- Jung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/#review34571
-----------------------------------------------------------
On Feb. 14, 2014, 9:43 a.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18112/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2014, 9:43 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-530
> https://issues.apache.org/jira/browse/TAJO-530
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Fix warnings in tajo-catalog.
>
>
> Diffs
> -----
>
> dev-support/findbugs-exclude.xml 0f967de
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java 2f57ff2
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/MutableBoolean.java PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java 62d6e27
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
>
> Diff: https://reviews.apache.org/r/18112/diff/
>
>
> Testing
> -------
>
> mvn clean test findbugs:findbugs -Phcatalog-0.12.0
> mvn clean test findbugs:findbugs -Phcatalog-0.11.0
>
>
> Thanks,
>
> Jung JaeHwa
>
>
Re: Review Request 18112: TAJO-530: Fix warnings in tajo-catalog.
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18112/#review34571
-----------------------------------------------------------
I found some concurrency problems in the changes of catalog module.
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java
<https://reviews.apache.org/r/18112/#comment64699>
AtomicBoolean looks enough for this purpose. You don't need to implement this kind of class.
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/MutableBoolean.java
<https://reviews.apache.org/r/18112/#comment64700>
AtomicBoolean looks enough for this purpose. You don't need to implement this kind of class.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
<https://reviews.apache.org/r/18112/#comment64701>
What was the reasoning behind the removal of compareTo function?
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
<https://reviews.apache.org/r/18112/#comment64702>
Statement, PreparedStatement, and ResultSet should not be used as member variables. Many methods share them, so this kind of usages definitely causes concurrency problems.
- Hyunsik Choi
On Feb. 14, 2014, 6:43 p.m., Jung JaeHwa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18112/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2014, 6:43 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-530
> https://issues.apache.org/jira/browse/TAJO-530
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Fix warnings in tajo-catalog.
>
>
> Diffs
> -----
>
> dev-support/findbugs-exclude.xml 0f967de
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java 084d97c
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java e770b11
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java 2f57ff2
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java 5cc0de1
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java 1b0a9fe
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java ce42bea
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java f7c1342
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java d4a2c3e
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java f8d24b0
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java f796fff
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java 263e1dd
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/MutableBoolean.java PRE-CREATION
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java 62d6e27
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
>
> Diff: https://reviews.apache.org/r/18112/diff/
>
>
> Testing
> -------
>
> mvn clean test findbugs:findbugs -Phcatalog-0.12.0
> mvn clean test findbugs:findbugs -Phcatalog-0.11.0
>
>
> Thanks,
>
> Jung JaeHwa
>
>