[jira] Commented: (AXIS2C-121) Log implementation does not go through ops

["Pim Philipse (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AXIS2C-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639769#action_12639769 ] 

Pim Philipse commented on AXIS2C-121:
-------------------------------------

The function axutil_log_write() does go through ops, but the entire Axis2/c system relies for its logging on macro's like AXIS2_LOG_ERROR. And this particular one expands to axutil_log_impl_log_error, and that bypasses the ops and directly calls axutil_log_impl_write_to_file.
This causes confusion for my users, as they now have two log files they have to examine when something goes wrong. 
Axis2/c supplies all the features for a user to alter the log implementation, then ignores the new implementation and uses the axutil_log_impl_* functions. This is the case in versions 1.1.0 and 1.5.0.

Please reopen the issue, remove the axutil_log_impl_log_* functions, change the macro's and let them point to functions that do go through ops, like
#define AXIS2_LOG_ERROR axutil_log_error

AXIS2_EXTERN void AXIS2_CALL
axutil_log_error(
    axutil_log_t *log,
    const axis2_char_t *filename,
    const int linenumber,
    const axis2_char_t *format,
    ...)
{
        if (AXIS2_LOG_LEVEL_ERROR <= log->level)
        {
            char value[AXIS2_LEN_VALUE + 1];
            va_list ap;
            va_start(ap, format);
            AXIS2_VSNPRINTF(value, AXIS2_LEN_VALUE, format, ap);
            va_end(ap);
            axutil_log_write(log, value, AXIS2_LOG_LEVEL_ERROR,
                filename, linenumber);
        }
}

> Log implementation does not go through ops
> ------------------------------------------
>
>                 Key: AXIS2C-121
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-121
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: util
>         Environment: Linux/Windows
>            Reporter: Nabeel Yoosuf
>            Assignee: Samisa Abeysinghe
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> The log implemenation does not go through ops; as a result of that a user cannot plug his/her log implementation to use the engine. It would be better if we can have it aleast for Linux since there's a known problem with accessing fucntions with variable no of arguments through macros in windows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org