You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/15 16:30:10 UTC
[GitHub] [spark] anuragmantri opened a new pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
anuragmantri opened a new pull request #30058:
URL: https://github.com/apache/spark/pull/30058
This is a backport of https://github.com/apache/spark/pull/27658
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In the PR, I propose to add the `legacySizeOfNull ` parameter to the `Size` expression, and pass the value of `spark.sql.legacy.sizeOfNull` if `legacySizeOfNull` is not provided on creation of `Size`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This allows to avoid the issue when the configuration change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
By `CollectionExpressionsSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709476752
**[Test build #129849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129849/testReport)** for PR 30058 at commit [`4edbefd`](https://github.com/apache/spark/commit/4edbefd31659c1abeac677cc589ed627ada7f871).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709587342
Thank you so much, @anuragmantri and @MaxGekk .
Merged to branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709476752
**[Test build #129849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129849/testReport)** for PR 30058 at commit [`4edbefd`](https://github.com/apache/spark/commit/4edbefd31659c1abeac677cc589ed627ada7f871).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709447436
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709493757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709493727
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34455/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709584852
**[Test build #129849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129849/testReport)** for PR 30058 at commit [`4edbefd`](https://github.com/apache/spark/commit/4edbefd31659c1abeac677cc589ed627ada7f871).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Size(child: Expression, legacySizeOfNull: Boolean)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709493757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709585388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30058:
URL: https://github.com/apache/spark/pull/30058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709585388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709487408
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34455/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709473434
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709446700
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709446700
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30058: [SPARK-30894][SQL][2.4] Make Size's nullable independent from SQL config changes
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30058:
URL: https://github.com/apache/spark/pull/30058#issuecomment-709447436
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org