You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by on...@apache.org on 2017/07/17 04:39:36 UTC
camel git commit: CAMEL-11524-Add quoteReplacement
Repository: camel
Updated Branches:
refs/heads/master 41c6c0ed4 -> 1fa638ec1
CAMEL-11524-Add quoteReplacement
Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/1fa638ec
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/1fa638ec
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/1fa638ec
Branch: refs/heads/master
Commit: 1fa638ec156135ef9d5c6bb8684b81459c6c7c82
Parents: 41c6c0e
Author: onders86 <on...@gmail.com>
Authored: Sat Jul 15 08:33:59 2017 +0300
Committer: onders86 <on...@gmail.com>
Committed: Mon Jul 17 07:38:58 2017 +0300
----------------------------------------------------------------------
.../component/file/GenericFileEndpoint.java | 3 +-
.../file/FileConsumeDoneFileIssueTest.java | 30 ++++++++++++++++++++
2 files changed, 32 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/camel/blob/1fa638ec/camel-core/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java b/camel-core/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java
index 0bea0ba..f60b12a 100644
--- a/camel-core/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java
+++ b/camel-core/src/main/java/org/apache/camel/component/file/GenericFileEndpoint.java
@@ -23,6 +23,7 @@ import java.util.Comparator;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.apache.camel.CamelContext;
@@ -1316,7 +1317,7 @@ public abstract class GenericFileEndpoint<T> extends ScheduledPollEndpoint imple
// we only support ${file:name} or ${file:name.noext} as dynamic placeholders for done files
String path = FileUtil.onlyPath(fileName);
- String onlyName = FileUtil.stripPath(fileName);
+ String onlyName = Matcher.quoteReplacement(FileUtil.stripPath(fileName));
pattern = pattern.replaceFirst("\\$\\{file:name\\}", onlyName);
pattern = pattern.replaceFirst("\\$simple\\{file:name\\}", onlyName);
http://git-wip-us.apache.org/repos/asf/camel/blob/1fa638ec/camel-core/src/test/java/org/apache/camel/component/file/FileConsumeDoneFileIssueTest.java
----------------------------------------------------------------------
diff --git a/camel-core/src/test/java/org/apache/camel/component/file/FileConsumeDoneFileIssueTest.java b/camel-core/src/test/java/org/apache/camel/component/file/FileConsumeDoneFileIssueTest.java
index 6b09323..bdedc37 100644
--- a/camel-core/src/test/java/org/apache/camel/component/file/FileConsumeDoneFileIssueTest.java
+++ b/camel-core/src/test/java/org/apache/camel/component/file/FileConsumeDoneFileIssueTest.java
@@ -89,6 +89,36 @@ public class FileConsumeDoneFileIssueTest extends ContextTestSupport {
assertFalse("Done file should be deleted", new File("target/done2/c.txt.done").exists());
}
+
+ public void testFileDoneFileNameContainingDollarSign() throws Exception {
+ NotifyBuilder notify = new NotifyBuilder(context).whenDone(3).create();
+
+ template.sendBodyAndHeader("file:target/done2", "A", Exchange.FILE_NAME, "$a$.txt");
+ template.sendBodyAndHeader("file:target/done2", "B", Exchange.FILE_NAME, "$b.txt");
+ template.sendBodyAndHeader("file:target/done2", "C", Exchange.FILE_NAME, "c$.txt");
+ template.sendBodyAndHeader("file:target/done2", "a", Exchange.FILE_NAME, "$a$.txt.done");
+ template.sendBodyAndHeader("file:target/done2", "b", Exchange.FILE_NAME, "$b.txt.done");
+ template.sendBodyAndHeader("file:target/done2", "c", Exchange.FILE_NAME, "c$.txt.done");
+
+ assertTrue("Done file should exists", new File("target/done2/$a$.txt.done").exists());
+ assertTrue("Done file should exists", new File("target/done2/$b.txt.done").exists());
+ assertTrue("Done file should exists", new File("target/done2/c$.txt.done").exists());
+
+ getMockEndpoint("mock:result").expectedBodiesReceivedInAnyOrder("A", "B", "C");
+
+ context.startRoute("bar");
+
+ assertMockEndpointsSatisfied();
+ assertTrue(notify.matchesMockWaitTime());
+
+ Thread.sleep(50);
+
+ // the done file should be deleted
+ assertFalse("Done file should be deleted", new File("target/done2/$a$.txt.done").exists());
+ assertFalse("Done file should be deleted", new File("target/done2/$b.txt.done").exists());
+ assertFalse("Done file should be deleted", new File("target/done2/c$.txt.done").exists());
+
+ }
@Override
protected RouteBuilder createRouteBuilder() throws Exception {