You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2021/02/23 19:54:13 UTC

[Impala-ASF-CR] IMPALA-10496: Bump springframework dependency to 4.3.29 

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17112


Change subject: IMPALA-10496: Bump springframework dependency to 4.3.29
......................................................................

IMPALA-10496: Bump springframework dependency to 4.3.29

Impala depended on springframework 4.3.19 through pac4j
since IMPALA-10496.

Testing:
- used dependency-check-maven plugin to check that the CVEs
  related to springframework disappear

Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
---
M fe/pom.xml
M java/pom.xml
2 files changed, 11 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/17112/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
Gerrit-Change-Number: 17112
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-10496: Bump springframework dependency to 4.3.29

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17112 )

Change subject: IMPALA-10496: Bump springframework dependency to 4.3.29
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8208/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
Gerrit-Change-Number: 17112
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 20:13:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10496: Bump springframework dependency to 4.3.29

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17112 )

Change subject: IMPALA-10496: Bump springframework dependency to 4.3.29
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6916/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
Gerrit-Change-Number: 17112
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 20:26:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10496: Bump springframework dependency to 4.3.29

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17112 )

Change subject: IMPALA-10496: Bump springframework dependency to 4.3.29
......................................................................

IMPALA-10496: Bump springframework dependency to 4.3.29

Impala depended on springframework 4.3.19 through pac4j
since IMPALA-10496.

Testing:
- used dependency-check-maven plugin to check that the CVEs
  related to springframework disappear

Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
Reviewed-on: http://gerrit.cloudera.org:8080/17112
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
M java/pom.xml
2 files changed, 11 insertions(+), 1 deletion(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
Gerrit-Change-Number: 17112
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10496: Bump springframework dependency to 4.3.29

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17112 )

Change subject: IMPALA-10496: Bump springframework dependency to 4.3.29
......................................................................


Patch Set 1: Code-Review+2

This makes sense to me. Thanks for fixing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/17112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
Gerrit-Change-Number: 17112
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 20:14:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10496: Bump springframework dependency to 4.3.29

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17112 )

Change subject: IMPALA-10496: Bump springframework dependency to 4.3.29
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a2b00a0dd1b1560fa97a13ccf4cf6bb69b4b51
Gerrit-Change-Number: 17112
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Feb 2021 02:12:09 +0000
Gerrit-HasComments: No