You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/07 07:24:50 UTC
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5923
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
IMPALA-4643: [DOCS] Set up many new keydefs
Make keydefs corresponding to most of the links
(especially external links) throughout the doc source.
Make keydefs for all possible IMPALA- JIRA issues, up to
IMPALA-9999.
Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
---
M docs/impala_keydefs.ditamap
1 file changed, 9,837 insertions(+), 194 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5923/1
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
IMPALA-4643: [DOCS] Set up many new keydefs
Make keydefs corresponding to most of the links
(especially external links) throughout the doc source.
Make keydefs for all possible IMPALA- JIRA issues, up to
IMPALA-9999.
Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
---
M docs/impala_keydefs.ditamap
1 file changed, 9,836 insertions(+), 193 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/5923/2
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
IMPALA-4643: [DOCS] Set up many new keydefs
Make keydefs corresponding to most of the links
(especially external links) throughout the doc source.
Make keydefs for all possible IMPALA- JIRA issues, up to
IMPALA-9999.
Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Reviewed-on: http://gerrit.cloudera.org:8080/5923
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Tested-by: Impala Public Jenkins
Reviewed-by: John Russell <jr...@cloudera.com>
---
M docs/impala_keydefs.ditamap
1 file changed, 9,836 insertions(+), 193 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Ambreen Kazi: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5923/1/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:
Line 10531: <keydef href="topics/impala_breakpad.xml" keys="breakpad"/>
> should this be just 'breakpad'?
There's another 'breakpad' which is the breakpad _project_ page. Why don't I strip off the .xml suffix here and rename that other "breakpad" key.
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/37/
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/36/
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: IMPALA-4643: [DOCS] Set up many new keydefs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5923/1/docs/impala_keydefs.ditamap
File docs/impala_keydefs.ditamap:
Line 10531: <keydef href="topics/impala_breakpad.xml" keys="breakpad.xml"/>
should this be just 'breakpad'?
--
To view, visit http://gerrit.cloudera.org:8080/5923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57c5730f80fd32ee77b31849e4e75afd53fab38
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes