You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/06/15 17:46:33 UTC

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority 

Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13659


Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................

[maintenance] Add extra config for maintenance manager task priority

While set and update priorities for multiply tables by GFlags is a
compromise, now we can improve it by extra config of tables.

Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
---
M src/kudu/common/common.proto
M src/kudu/common/wire_protocol.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_mm_ops.h
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/tablet_replica_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.h
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
11 files changed, 68 insertions(+), 90 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/13659/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "XiaokaiWang (Code Review)" <ge...@cloudera.org>.
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/common.proto
File src/kudu/common/common.proto:

PS2: 
> Do you think we should update all of the tests that xiaokai updated (https:
Do we need to confirm that it works  on all respects? I think it is needed.



-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 15:59:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13659

to look at the new patch set (#2).

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................

[maintenance] Add extra config for maintenance manager task priority

While set and update priorities for multiply tables by GFlags is a
compromise, now we can improve it by extra config of tables.

Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
---
M src/kudu/common/common.proto
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_mm_ops.h
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/tablet_replica_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.h
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
12 files changed, 78 insertions(+), 93 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/13659/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/common.proto
File src/kudu/common/common.proto:

PS2: 
Do you think we should update all of the tests that xiaokai updated (https://gerrit.cloudera.org/c/13796) every time a new extra config is added?


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/common.proto@449
PS2, Line 449: valid priority level is ranged
             :   // in [-FLAGS_max_priority_range, FLAGS_max_priority_range]
Hmm, but --max_priority_range can change. What's the expected behavior if it's changed such that maintenance_priority is no longer within the range?

Looking at the rest of the patch, it looks like we clamp maintenance_priority to the range defined by [-range, range]. Perhaps you could rephrase this comment to explain that?


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.h@154
PS2, Line 154: Int
Nit: Int32 to be clearer about the size.


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.cc@666
PS2, Line 666: Status ParseIntConfig(const std::string& name, const std::string& value, int32_t* result) {
No need for std:: prefixes here.


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.cc@669
PS2, Line 669: Unable
Nit: "unable to..." because we often prepend other messages to a status.


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/tablet/tablet_mm_ops.cc@96
PS2, Line 96:   if (tablet_->metadata()->extra_config() &&
            :       tablet_->metadata()->extra_config()->has_maintenance_priority()) {
            :     priority = tablet_->metadata()->extra_config()->maintenance_priority();
            :   }
This pattern (and the equivalent in tablet_replica_mm_ops.cc) doesn't seem correct from a synchronization perspective. There are three accesses to extra_config() and each one acquires TabletMetadata.data_lock_, which means the returned value could be different each time, reflecting the results of a concurrent AlterSchema. Seems like the right thing would be to call extra_config once, store a copy of the extra config locally, then operate on it.

It's also a little concerning that this wasn't surfaced in a unit test. Could you try to repro this race with the code as-is via a new test?



-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 04:23:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 1: Code-Review+1

LGTM


-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Sat, 22 Jun 2019 00:44:07 +0000
Gerrit-HasComments: No

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 3:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/common.proto
File src/kudu/common/common.proto:

PS2: 
> Do you think we should update all of the tests that xiaokai updated (https:
I don't think it's necessary, we should assume that 'table extra config' is a stable feature, not needed to test it again and again. However, functional test for the new added config is needed.


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/common.proto@449
PS2, Line 449: ance, it will be clamped into
             :   // range [-FLAGS_max_priority_range, FLAGS_max_priority_ran
> Hmm, but --max_priority_range can change. What's the expected behavior if i
Done


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.h@154
PS2, Line 154: Int
> Nit: Int32 to be clearer about the size.
Done


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.cc@666
PS2, Line 666: Status ParseInt32Config(const string& name, const string& value, int32_t* result) {
> No need for std:: prefixes here.
Done


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/wire_protocol.cc@669
PS2, Line 669: unable
> Nit: "unable to..." because we often prepend other messages to a status.
Done


http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/tablet/tablet_mm_ops.cc
File src/kudu/tablet/tablet_mm_ops.cc:

http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/tablet/tablet_mm_ops.cc@96
PS2, Line 96:   const auto& extra_config = tablet_->metadata()->extra_config();
            :   if (extra_config && extra_config->has_maintenance_priority()) {
            :     priority = extra_config->maintenance_priority();
            :   }
> This pattern (and the equivalent in tablet_replica_mm_ops.cc) doesn't seem 
I'll add an unit test to check OPs priority after alter this extra config, but I don't think it's necessary to repro this race, because there is no race after the prior patch set.



-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 04:22:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 15:01:48 +0000
Gerrit-HasComments: No

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc@681
PS1, Line 681:         int32_t history_max_age_sec;
             :         RETURN_NOT_OK(ParseIntConfig(name, value, &history_max_age_sec));
             :         result.set_history_max_age_sec(history_max_age_sec);
             :       }
> Maybe we can optimize the duplicate code here.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Sun, 23 Jun 2019 06:11:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, XiaokaiWang, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13659

to look at the new patch set (#3).

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................

[maintenance] Add extra config for maintenance manager task priority

While set and update priorities for multiply tables by GFlags is a
compromise, now we can improve it by extra config of tables.

Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
---
M src/kudu/common/common.proto
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_mm_ops.h
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/tablet_replica_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.h
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
13 files changed, 116 insertions(+), 96 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/13659/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/13659/1/src/kudu/common/wire_protocol.cc@681
PS1, Line 681:         int32_t maintenance_priority;
             :         if (!safe_strto32(value, &maintenance_priority)) {
             :           return Status::InvalidArgument(Substitute("Unable to parse $0", name), value);
             :         }
Maybe we can optimize the duplicate code here.



-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Sat, 22 Jun 2019 02:54:55 +0000
Gerrit-HasComments: Yes

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................

[maintenance] Add extra config for maintenance manager task priority

While set and update priorities for multiply tables by GFlags is a
compromise, now we can improve it by extra config of tables.

Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Reviewed-on: http://gerrit.cloudera.org:8080/13659
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Yingchun Lai <40...@qq.com>
---
M src/kudu/common/common.proto
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_mm_ops.cc
M src/kudu/tablet/tablet_mm_ops.h
M src/kudu/tablet/tablet_replica.h
M src/kudu/tablet/tablet_replica_mm_ops.cc
M src/kudu/tablet/tablet_replica_mm_ops.h
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
13 files changed, 116 insertions(+), 96 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Yingchun Lai: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Sun, 14 Jul 2019 02:57:26 +0000
Gerrit-HasComments: No

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Removed Verified+1 by Yingchun Lai <40...@qq.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [maintenance] Add extra config for maintenance manager task priority

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 )

Change subject: [maintenance] Add extra config for maintenance manager task priority
......................................................................


Patch Set 3: Code-Review+2

Test failure looks unrelated.


-- 
To view, visit http://gerrit.cloudera.org:8080/13659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867
Gerrit-Change-Number: 13659
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: XiaokaiWang <xi...@live.com>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 05:01:52 +0000
Gerrit-HasComments: No