You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2016/09/13 21:53:20 UTC

qpid-jms git commit: QPIDJMS-207 Add additional coverage of new JMS 2.0 API implementations

Repository: qpid-jms
Updated Branches:
  refs/heads/master 7d449fff1 -> d35ea7680


QPIDJMS-207 Add additional coverage of new JMS 2.0 API implementations


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/d35ea768
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/d35ea768
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/d35ea768

Branch: refs/heads/master
Commit: d35ea76801fb626b80003522ab17fff056b8da7a
Parents: 7d449ff
Author: Timothy Bish <ta...@gmail.com>
Authored: Tue Sep 13 17:45:12 2016 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Tue Sep 13 17:53:04 2016 -0400

----------------------------------------------------------------------
 .../org/apache/qpid/jms/JmsConnectionTest.java  | 27 +++++++
 .../apache/qpid/jms/session/JmsSessionTest.java | 79 ++++++++++++++++++++
 2 files changed, 106 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/d35ea768/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsConnectionTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsConnectionTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsConnectionTest.java
index 4928faa..329b541 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsConnectionTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/JmsConnectionTest.java
@@ -184,6 +184,27 @@ public class JmsConnectionTest {
         }
     }
 
+    @Test(timeout=30000)
+    public void testCreateSessionWithUnknownAckMode() throws JMSException, IOException {
+        connection = new JmsConnection("ID:TEST:1", provider, clientIdGenerator);
+        connection.start();
+
+        try {
+            connection.createSession(99);
+            fail("Should not allow unkown Ack modes.");
+        } catch (JMSException ex) {
+        }
+    }
+
+    @Test(timeout=30000)
+    public void testCreateSessionDefaultMode() throws JMSException, IOException {
+        connection = new JmsConnection("ID:TEST:1", provider, clientIdGenerator);
+        connection.start();
+
+        JmsSession session = (JmsSession) connection.createSession();
+        assertEquals(session.getSessionMode(), Session.AUTO_ACKNOWLEDGE);
+    }
+
     @Test(timeout=30000, expected=InvalidClientIDException.class)
     public void testSetClientIDFromEmptyString() throws JMSException, IOException {
         connection = new JmsConnection("ID:TEST:1", provider, clientIdGenerator);
@@ -266,6 +287,12 @@ public class JmsConnectionTest {
     }
 
     @Test(timeout=30000, expected=JMSException.class)
+    public void testCreateDurableConnectionQueueConsumer() throws Exception {
+        connection = new JmsConnection("ID:TEST:1", provider, clientIdGenerator);
+        connection.createDurableConnectionConsumer(new JmsTopic(), "", "", null, 1);
+    }
+
+    @Test(timeout=30000, expected=JMSException.class)
     public void testCreateSharedConnectionConsumer() throws Exception {
         connection = new JmsConnection("ID:TEST:1", provider, clientIdGenerator);
         connection.createSharedConnectionConsumer(new JmsTopic(), "id", "", null, 1);

http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/d35ea768/qpid-jms-client/src/test/java/org/apache/qpid/jms/session/JmsSessionTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/session/JmsSessionTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/session/JmsSessionTest.java
index 4524146..531828a 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/session/JmsSessionTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/session/JmsSessionTest.java
@@ -23,6 +23,7 @@ import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
 import javax.jms.IllegalStateException;
+import javax.jms.InvalidDestinationException;
 import javax.jms.JMSException;
 import javax.jms.Message;
 import javax.jms.MessageListener;
@@ -187,4 +188,82 @@ public class JmsSessionTest extends JmsConnectionTestSupport {
         JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
         session.unsubscribe("some-subscription");
     }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateConsumerNullDestinationThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createConsumer(null);
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateConsumerNullDestinationWithSelectorThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createConsumer(null, "a > b");
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateConsumerNullDestinationWithSelectorNoLocalThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createConsumer(null, "a > b", true);
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateReceiverNullDestinationThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createReceiver(null);
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateReceiverNullDestinationWithSelectorThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createConsumer(null, "a > b");
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateBrowserNullDestinationThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createBrowser(null);
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateBrowserNullDestinationWithSelectorThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createBrowser(null, "a > b");
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateSubscriberNullDestinationThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createSubscriber(null);
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateSubscriberNullDestinationWithSelectorNoLocalThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createSubscriber(null, "a > b", true);
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateDurableSubscriberNullDestinationThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createDurableSubscriber(null, "name");
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateDurableSubscriberNullDestinationWithSelectorNoLocalThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createDurableSubscriber(null, "name", "a > b", true);
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateDurableConsumerNullDestinationThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createDurableConsumer(null, "name");
+    }
+
+    @Test(timeout = 10000, expected=InvalidDestinationException.class)
+    public void testCreateDurableConsumerNullDestinationWithSelectorNoLocalThrowsIDE() throws JMSException {
+        JmsSession session = (JmsSession) connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
+        session.createDurableConsumer(null, "name", "a > b", true);
+    }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org