You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/19 01:30:16 UTC
[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #565:
HDDS-3030. Key Rename should preserve the ObjectID.
bharatviswa504 opened a new pull request #565: HDDS-3030. Key Rename should preserve the ObjectID.
URL: https://github.com/apache/hadoop-ozone/pull/565
## What changes were proposed in this pull request?
On Key Renames, objectID should be preserved from the original Key.
Currently it is being set to the new transactionLogIndex of the rename request.
Use original ObjectID from actual Key when renaming.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3030
## How was this patch tested?
Existing UT should cover this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request
#565: HDDS-3030. Key Rename should preserve the ObjectID.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #565: HDDS-3030. Key Rename should preserve the ObjectID.
URL: https://github.com/apache/hadoop-ozone/pull/565#discussion_r381478848
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequest.java
##########
@@ -210,15 +210,11 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
throw new OMException("Key not found " + fromKey, KEY_NOT_FOUND);
}
- // Copy fromKeyValue into toKeyValue and set objectID and updateID to
- // current transactionLogIndex
- toKeyValue = fromKeyValue.copyObject(false);
- toKeyValue.setObjectID(trxnLogIndex);
- toKeyValue.setUpdateID(trxnLogIndex);
Review comment:
Line no 213 does that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] hanishakoneru commented on issue #565: HDDS-3030.
Key Rename should preserve the ObjectID.
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on issue #565: HDDS-3030. Key Rename should preserve the ObjectID.
URL: https://github.com/apache/hadoop-ozone/pull/565#issuecomment-588389645
LGTM. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] hanishakoneru merged pull request #565: HDDS-3030.
Key Rename should preserve the ObjectID.
Posted by GitBox <gi...@apache.org>.
hanishakoneru merged pull request #565: HDDS-3030. Key Rename should preserve the ObjectID.
URL: https://github.com/apache/hadoop-ozone/pull/565
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request
#565: HDDS-3030. Key Rename should preserve the ObjectID.
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #565: HDDS-3030. Key Rename should preserve the ObjectID.
URL: https://github.com/apache/hadoop-ozone/pull/565#discussion_r381465806
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRenameRequest.java
##########
@@ -210,15 +210,11 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
throw new OMException("Key not found " + fromKey, KEY_NOT_FOUND);
}
- // Copy fromKeyValue into toKeyValue and set objectID and updateID to
- // current transactionLogIndex
- toKeyValue = fromKeyValue.copyObject(false);
- toKeyValue.setObjectID(trxnLogIndex);
- toKeyValue.setUpdateID(trxnLogIndex);
Review comment:
We should still set the UpdateID here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org