[GitHub] [inlong] EMsnap commented on a diff in pull request #4855: [INLONG-4854][Agent] Report metrics at inongGroupId and inlongStreamId

[GitBox <gi...@apache.org>]

EMsnap commented on code in PR #4855:
URL: https://github.com/apache/inlong/pull/4855#discussion_r913330945


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/AbstractSink.java:
##########
@@ -69,24 +62,24 @@ public void init(JobProfile jobConf) {
         inlongStreamId = jobConf.get(PROXY_INLONG_STREAM_ID, DEFAULT_PROXY_INLONG_STREAM_ID);
     }
 
-    /**
-     * init sinkMetric
-     *
-     * @param tagName metric tagName
-     */
-    protected void intMetric(String tagName) {
-        String label = Joiner.on(",").join(tagName, index.getAndIncrement());
-        if (ConfigUtil.isPrometheusEnabled()) {
-            sinkMetric = new SinkPrometheusMetrics(label);
-        } else {
-            sinkMetric = new SinkJmxMetric(label);
-        }
-        label = Joiner.on(",").join(tagName, inlongGroupId, inlongStreamId);
-        if (ConfigUtil.isPrometheusEnabled()) {
-            streamMetric = new SinkPrometheusMetrics(label);
-        } else {
-            streamMetric = new SinkJmxMetric(label);
-        }
-    }
+//    /**
+//     * init sinkMetric
+//     *
+//     * @param tagName metric tagName
+//     */
+//    protected void intMetric(String tagName) {
+//        String label = Joiner.on(",").join(tagName, index.getAndIncrement());
+//        if (ConfigUtil.isPrometheusEnabled()) {
+//            sinkMetric = new SinkPrometheusMetric(label);
+//        } else {
+//            sinkMetric = new SinkJmxMetric(label);

Review Comment:
   remove useless code directly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org