[jira] [Comment Edited] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

["Tomoko Uchida (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515701#comment-17515701 ] 

Tomoko Uchida edited comment on LUCENE-10485 at 4/1/22 5:22 AM:
----------------------------------------------------------------

Note: Found some IDE issues with white-box test under JPMS. The discussion seems to get stuck for years but maybe worth following... (In the sense that I got there is little hope to proceed this.)
Eclipse [https://bugs.eclipse.org/bugs/show_bug.cgi?id=559601]
IDEA [https://youtrack.jetbrains.com/issue/IDEA-222831]


was (Author: tomoko uchida):
Note: Found some IDE issues with white-box test under JPMS. The discussion seems to get stuck for years but maybe worth following...
Eclipse [https://bugs.eclipse.org/bugs/show_bug.cgi?id=559601]
IDEA [https://youtrack.jetbrains.com/issue/IDEA-222831]

> Limit o.a.l.a.morph package visibility only to kuromoji and nori
> ----------------------------------------------------------------
>
>                 Key: LUCENE-10485
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10485
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Tomoko Uchida
>            Priority: Minor
>         Attachments: hacky-poc-make-kuromoji-test-named-module.patch
>
>
> LUCENE-10393 added a new package {{org.apache.lucene.analysis.morph}} to analysis-common that is supposed to be used by only analysis-kuromoji and analysis-nori modules. It would be better to reduce its visibility (on module-mode) by "export to" clause in the module descriptor. 
> The major issue here may be unit tests. They also have to be converted to properly named modules otherwise they cannot access the {{o.a.l.a.morph}} package.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org