You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 06:00:35 UTC

[GitHub] [spark] viirya commented on a diff in pull request #38641: [SPARK-41126][K8S] `entrypoint.sh` should use its WORKDIR instead of `/tmp` directory

viirya commented on code in PR #38641:
URL: https://github.com/apache/spark/pull/38641#discussion_r1021102101


##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh:
##########
@@ -41,11 +41,11 @@ if [ -z "$JAVA_HOME" ]; then
 fi
 
 SPARK_CLASSPATH="$SPARK_CLASSPATH:${SPARK_HOME}/jars/*"
-env | grep SPARK_JAVA_OPT_ | sort -t_ -k4 -n | sed 's/[^=]*=\(.*\)/\1/g' > /tmp/java_opts.txt
+env | grep SPARK_JAVA_OPT_ | sort -t_ -k4 -n | sed 's/[^=]*=\(.*\)/\1/g' > java_opts.txt

Review Comment:
   So this will be `/opt/spark/work-dir/java_opts.txt`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org