[jira] [Commented] (INFRA-7745) Sanitize URLs passed to Buildbot SVN before continuing to check out

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/INFRA-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000463#comment-14000463 ] 

Sebb commented on INFRA-7745:
-----------------------------

The original suggestion seems like a very sensible check; I don't understand why it was rejected.

> Sanitize URLs passed to Buildbot SVN before continuing to check out
> -------------------------------------------------------------------
>
>                 Key: INFRA-7745
>                 URL: https://issues.apache.org/jira/browse/INFRA-7745
>             Project: Infrastructure
>          Issue Type: Improvement
>          Components: Buildbot
>         Environment: Buildbot
>            Reporter: Andy Gumbrecht
>            Assignee: Gavin
>
> Adding something like f.addStep(SVN(repourl=Interpolate("https://svn.apache.org/repos/asf/%(src::branch:-scm_path)s")))
> Defaults to an empty string if no property or variable is found. This leaves the URL:
> https://svn.apache.org/repos/asf/
> Which SVN then proceeds to check out without question - The entire ASF repo!
> I would suggest that if the URL does not at least contain trunk/branch/tag, or even just equals the root URL that the buildbot fails as this point.



--
This message was sent by Atlassian JIRA
(v6.2#6252)