You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bsf-dev@jakarta.apache.org by Fabrício Matheus Gonçalves <fm...@bigbross.com> on 2003/01/28 23:00:21 UTC

JavaScriptEngine.declareBean() patch

Hi all,

That is the code:

Index: bsf/src/org/apache/bsf/engines/javascript/JavaScriptEngine.java
===================================================================
RCS file:
/home/cvspublic/jakarta-bsf/src/bsf-2.3/bsf/src/org/apache/bsf/engines/javascript/JavaScriptEngine.java,v
retrieving revision 1.2
diff -u -r1.2 JavaScriptEngine.java
--- bsf/src/org/apache/bsf/engines/javascript/JavaScriptEngine.java     7
Nov 2002 01:49:12 -0000       1.2
+++ bsf/src/org/apache/bsf/engines/javascript/JavaScriptEngine.java     28
Jan 2003 21:54:52 -0000
@@ -193,9 +193,15 @@
     }

     public void declareBean(BSFDeclaredBean bean) throws BSFException {
-        // Must wrap non-scriptable objects before presenting to Rhino
-        Scriptable wrapped = Context.toObject(bean.bean, global);
-        global.put(bean.name, global, wrapped);
+       if ((bean.bean instanceof Number) ||
+           (bean.bean instanceof String) ||
+           (bean.bean instanceof Boolean)) {
+           global.put(bean.name, global, bean.bean);
+       } else {
+           // Must wrap non-scriptable objects before presenting to Rhino
+           Scriptable wrapped = Context.toObject(bean.bean, global);
+           global.put(bean.name, global, wrapped);
+       }
     }

     /**



Re: JavaScriptEngine.declareBean() patch

Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
On Tue, Jan 28, 2003 at 08:00:21PM -0200, Fabrício Matheus Gonçalves wrote:
> 
> That is the code:
> 

Applied shortly. Thanks!

Victor
-- 
Victor J. Orlikowski   | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org  | vjo@dulug.duke.edu | vjo@us.ibm.com