[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #18025: [DEV] switch nose with pytest

[GitBox <gi...@apache.org>]

ChaiBapchya commented on a change in pull request #18025:
URL: https://github.com/apache/incubator-mxnet/pull/18025#discussion_r418271451



##########
File path: ci/docker/runtime_functions.sh
##########
@@ -994,26 +991,24 @@ cd_unittest_ubuntu() {
 
     local mxnet_variant=${1:?"This function requires a mxnet variant as the first argument"}
 
-    local nose_cmd="nosetests-3.4"
-
-    $nose_cmd $NOSE_TIMER_ARGUMENTS --verbose tests/python/unittest
-    $nose_cmd $NOSE_TIMER_ARGUMENTS --verbose tests/python/quantization
+    pytest --durations=50 --verbose tests/python/unittest
+    pytest --durations=50 --verbose tests/python/quantization
 
     # https://github.com/apache/incubator-mxnet/issues/11801
     # if [[ ${mxnet_variant} = "cpu" ]] || [[ ${mxnet_variant} = "mkl" ]]; then
         # integrationtest_ubuntu_cpu_dist_kvstore
     # fi
 
     if [[ ${mxnet_variant} = cu* ]]; then
-        $nose_cmd $NOSE_TIMER_ARGUMENTS --verbose tests/python/gpu
+        pytest --durations=50 --verbose tests/python/gpu

Review comment:
       why are we showing top 50 slowest duration only?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org