You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2017/03/31 19:00:46 UTC
[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/535
CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project
### Platforms affected
iOS
### What does this PR do?
Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform
### What testing has been done on this change?
Unit tests are in the iOS platform, through the Platform API, see: https://github.com/apache/cordova-ios/pull/299
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-XXXX"
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11233-b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/535.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #535
----
commit d77dfa807b00770e33281a3207bd6a250b0d9ab3
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-03-31T18:59:10Z
CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...
Posted by shazron <gi...@git.apache.org>.
Github user shazron closed the pull request at:
https://github.com/apache/cordova-lib/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...
Posted by shazron <gi...@git.apache.org>.
GitHub user shazron reopened a pull request:
https://github.com/apache/cordova-lib/pull/535
CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project
### Platforms affected
iOS
### What does this PR do?
Support the "embed" attribute for the `<framework>` tag of plugin.xml to facilitate installing custom iOS frameworks into the Embedded Binaries section of the Xcode project for the iOS platform
### What testing has been done on this change?
Unit tests are in the iOS platform, through the Platform API, see: https://github.com/apache/cordova-ios/pull/299
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-XXXX"
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11233-b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/535.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #535
----
commit d77dfa807b00770e33281a3207bd6a250b0d9ab3
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-03-31T18:59:10Z
CB-11233 - Support installing frameworks into 'Embedded Binaries' section of the Xcode project
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #535: CB-11233 - Support installing frameworks into 'Embed...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/535
e2e tests were failing because of the new cordova-android@6.2.0 release. We rolled back the `latest` tag to cordova-android@6.1.2 and re-tested locally, e2e tests pass now. I am re-running the CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #535: CB-11233 - Support installing frameworks into 'Embed...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/535
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=h1) Report
> Merging [#535](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/4c99c0d4e08c5a48ab5d2d48e627b58c45c4b8d2?src=pr&el=desc) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 82.42% 82.78% +0.36%
==========================================
Files 68 65 -3
Lines 5461 5431 -30
Branches 1070 1067 -3
==========================================
- Hits 4501 4496 -5
+ Misses 960 935 -25
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | | |
| [cordova-lib/src/plugman/info.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5mby5qcw==) | | |
| [cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=) | | |
| [cordova-lib/src/plugman/create.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vY3JlYXRlLmpz) | | |
| [cordova-lib/src/cordova/cordova.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvY29yZG92YS5qcw==) | | |
| [cordova-lib/src/plugman/config.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vY29uZmlnLmpz) | | |
| [cordova-lib/src/plugman/platform.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm0uanM=) | | |
| [cordova-lib/src/cordova/create.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvY3JlYXRlLmpz) | | |
| [cordova-lib/src/cordova/run.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcnVuLmpz) | | |
| [cordova-lib/src/plugman/platforms/android.js](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vcGxhdGZvcm1zL2FuZHJvaWQuanM=) | | |
| ... and [16 more](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=footer). Last update [4c99c0d...d77dfa8](https://codecov.io/gh/apache/cordova-lib/pull/535?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #535: CB-11233 - Support installing frameworks into...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org