You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by rahulforallp <gi...@git.apache.org> on 2018/03/27 06:52:43 UTC
[GitHub] carbondata pull request #2107: [CARBONDATA-2287] events added for alter hive...
GitHub user rahulforallp opened a pull request:
https://github.com/apache/carbondata/pull/2107
[CARBONDATA-2287] events added for alter hive partition table
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed? No
- [ ] Any backward compatibility impacted? No
- [ ] Document update required? No
- [ ] Testing done NR, All UT and SDV pass report is enough.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-2287
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2107
----
commit 7f46f86e2fcaaf385dfe426ecc0617155401cca7
Author: rahulforallp <ra...@...>
Date: 2018-03-27T06:50:04Z
[CARBONDATA-2287] events added for alter hive partition table
----
---
[GitHub] carbondata pull request #2107: [CARBONDATA-2287] events added for alter hive...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2107
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4130/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4133/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3384/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4612/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4113/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4117/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2107
LGTM
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4620/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3400/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4110/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3397/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4629/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/2107
retest sdv please
---
[GitHub] carbondata pull request #2107: [CARBONDATA-2287] events added for alter hive...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2107#discussion_r177410099
--- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java ---
@@ -338,7 +339,23 @@ public static CarbonFactDataHandlerModel getCarbonFactDataHandlerModel(CarbonLoa
*/
private static String getCarbonDataFolderLocation(CarbonDataLoadConfiguration configuration) {
if (configuration.getDataWritePath() != null) {
- CarbonUtil.checkAndCreateFolder(configuration.getDataWritePath());
+ String paths = configuration.getDataWritePath();
+ AbsoluteTableIdentifier absoluteTableIdentifier = configuration.getTableIdentifier();
+ String partPath = absoluteTableIdentifier.getTablePath();
+ String[] partDirs = paths.split(partPath);
+ // it will create folder one by one and apply the permissions
+ // else creation of folder in one go will set the permission for last directory only
+ if (partDirs.length > 1) {
--- End diff --
Can you add an example above with paths or partDirs for better understanding
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3387/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3395/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3404/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4137/
---
[GitHub] carbondata pull request #2107: [CARBONDATA-2287] events added for alter hive...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2107#discussion_r177409405
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/converter/impl/MeasureFieldConverterImpl.java ---
@@ -95,8 +95,9 @@ public void convert(CarbonRow row, BadRecordLogHolder logHolder)
}
row.update(output, index);
} catch (NumberFormatException e) {
- LOGGER.warn(
- "Cant not convert value to Numeric type value. Value considered as null.");
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.warn("Can not convert value to Numeric type value. Value considered as null.");
--- End diff --
Change it to Logger.debug
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3401/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4125/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4132/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4126/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4112/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2107
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4123/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4626/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3390/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4615/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4625/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4609/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2107
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4622/
---
[GitHub] carbondata issue #2107: [CARBONDATA-2287] events added for alter hive partit...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on the issue:
https://github.com/apache/carbondata/pull/2107
retest sdv please
---