You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/11 21:48:31 UTC
[GitHub] [tvm] yongwww commented on a diff in pull request #12385: [Target] Fix C5 Target Tag to Include CascadeLake Archs
yongwww commented on code in PR #12385:
URL: https://github.com/apache/tvm/pull/12385#discussion_r943966663
##########
src/target/tag.cc:
##########
@@ -349,19 +349,18 @@ TVM_REGISTER_CUDA_TAG("nvidia/tegra-x1", "sm_53", 49152, 32768);
#undef TVM_REGISTER_CUDA_TAG
-#define TVM_REGISTER_TAG_AWS_C5(Name, Cores) \
- TVM_REGISTER_TARGET_TAG(Name).set_config({{"kind", String("llvm")}, \
- {"mcpu", String("skylake-avx512")}, \
- {"num-cores", Integer(Cores)}});
+#define TVM_REGISTER_TAG_AWS_C5(Name, Cores, Arch) \
+ TVM_REGISTER_TARGET_TAG(Name).set_config( \
+ {{"kind", String("llvm")}, {"mcpu", String(Arch)}, {"num-cores", Integer(Cores)}});
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.large", 1);
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.xlarge", 2);
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.2xlarge", 4);
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.4xlarge", 8);
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.9xlarge", 18);
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.12xlarge", 24);
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.18xlarge", 36);
-TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.24xlarge", 48);
+TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.large", 1, "skylake-avx512");
+TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.xlarge", 2, "skylake-avx512");
+TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.2xlarge", 4, "skylake-avx512");
+TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.4xlarge", 8, "skylake-avx512");
+TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.9xlarge", 18, "skylake-avx512");
+TVM_REGISTER_TAG_AWS_C5("aws/cpu/c5.12xlarge", 24, "cascadelake");
Review Comment:
> I'm not quite sure if we need to use `cascadelake-avx512` here.
I don't think we need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org