You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/21 19:11:59 UTC
Re: Review Request: Fixed a memory leak bug in stout/result.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9512/#review18220
-----------------------------------------------------------
third_party/libprocess/include/stout/result.hpp
<https://reviews.apache.org/r/9512/#comment38420>
Jie. Can you rebase this off the latest trunk. The stout files have moved around. Thanks!
- Vinod Kone
On Feb. 19, 2013, 2:45 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9512/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2013, 2:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> The old object needs to be deleted in the assignment operator overload function.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/stout/result.hpp 3326da0
>
> Diff: https://reviews.apache.org/r/9512/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Fixed a memory leak bug in stout/result.hpp.
Posted by Jie Yu <yu...@gmail.com>.
> On March 21, 2013, 6:12 p.m., Vinod Kone wrote:
> > third_party/libprocess/include/stout/result.hpp, line 51
> > <https://reviews.apache.org/r/9512/diff/1/?file=259691#file259691line51>
> >
> > Jie. Can you rebase this off the latest trunk. The stout files have moved around. Thanks!
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9512/#review18220
-----------------------------------------------------------
On April 12, 2013, 2:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9512/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 2:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> The old object needs to be deleted in the assignment operator overload function.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/result.hpp 3326da0
>
> Diff: https://reviews.apache.org/r/9512/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>