You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/01 04:20:16 UTC

[kudu-CR] transaction tracker: back-off when logging in-flight transactions

Todd Lipcon has posted comments on this change.

Change subject: transaction_tracker: back-off when logging in-flight transactions
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4159/1/src/kudu/tablet/transactions/transaction_tracker.cc
File src/kudu/tablet/transactions/transaction_tracker.cc:

Line 207:   MonoTime next_log_time = start_time + MonoDelta::FromSeconds(1);
> can you pull the log backoff logic into a generic logging helper, seems lik
not sure how to do that in a nice way since we're also using the times for timeout calculation, etc


-- 
To view, visit http://gerrit.cloudera.org:8080/4159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d1a2563dd57c59ae8c130a5b26966f4964048de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes